From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] sil3531: has no PM capability, remove support. Date: Mon, 09 Apr 2012 10:51:17 -0400 Message-ID: <4F82F765.4010705@pobox.com> References: <1333980849.11209.5.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-qa0-f42.google.com ([209.85.216.42]:34397 "EHLO mail-qa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757218Ab2DIOvV (ORCPT ); Mon, 9 Apr 2012 10:51:21 -0400 In-Reply-To: <1333980849.11209.5.camel@localhost.localdomain> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: philby john Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, htejun@gmail.com On 04/09/2012 10:14 AM, philby john wrote: > From: Philby John > Date: Mon, 9 Apr 2012 19:09:51 +0530 > Subject: [PATCH] sil3531: has no PM capability, remove support. > > SATA sil3531 does not support Power Management Capability and > as per the manual Bit [31:27] is hardwired to 00h. > Otherwise, when the device goes into suspend/resume the Power > Management Control + Status registers are accessed and the > arch specific readl()/__raw_readl() calls block indefinitely. > > This patch sets the PCI_DEV_FLAGS_NO_D3 flag by which the if > condition in pci_set_power_state() evaluates to true and > pci_raw_set_power_state() functions are not executed. > > Signed-off-by: Philby John > Signed-off-by: Johnny Chiang > --- > drivers/pci/pci.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index 8156744..129120d 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -1863,6 +1863,7 @@ void pci_pm_init(struct pci_dev *dev) > pci_pme_active(dev, false); > } else { > dev->pme_support = 0; > + dev->dev_flags |= PCI_DEV_FLAGS_NO_D3; This patch applies to -every- piece of PCI hardware out there, not just the sil3531... Jeff