* [PATCH] ata/pata_arasan_cf: Move arasan_cf_pm_ops out of #ifdef, #endif macros
@ 2012-03-01 8:04 Viresh Kumar
2012-03-23 8:08 ` Viresh Kumar
2012-04-10 9:32 ` Viresh Kumar
0 siblings, 2 replies; 5+ messages in thread
From: Viresh Kumar @ 2012-03-01 8:04 UTC (permalink / raw)
To: jgarzik; +Cc: linux-ide, spear-devel, viresh.linux, Viresh Kumar
#ifdef, #endif is not required in definition/usage of arasan_cf_pm_ops. So, move
this definition and its usage outside of them.
Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
---
drivers/ata/pata_arasan_cf.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
index fc2db2a..3239517 100644
--- a/drivers/ata/pata_arasan_cf.c
+++ b/drivers/ata/pata_arasan_cf.c
@@ -943,9 +943,9 @@ static int arasan_cf_resume(struct device *dev)
return 0;
}
+#endif
static SIMPLE_DEV_PM_OPS(arasan_cf_pm_ops, arasan_cf_suspend, arasan_cf_resume);
-#endif
static struct platform_driver arasan_cf_driver = {
.probe = arasan_cf_probe,
@@ -953,9 +953,7 @@ static struct platform_driver arasan_cf_driver = {
.driver = {
.name = DRIVER_NAME,
.owner = THIS_MODULE,
-#ifdef CONFIG_PM
.pm = &arasan_cf_pm_ops,
-#endif
},
};
--
1.7.8.110.g4cb5d
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ata/pata_arasan_cf: Move arasan_cf_pm_ops out of #ifdef, #endif macros
2012-03-01 8:04 [PATCH] ata/pata_arasan_cf: Move arasan_cf_pm_ops out of #ifdef, #endif macros Viresh Kumar
@ 2012-03-23 8:08 ` Viresh Kumar
2012-04-10 9:32 ` Viresh Kumar
1 sibling, 0 replies; 5+ messages in thread
From: Viresh Kumar @ 2012-03-23 8:08 UTC (permalink / raw)
To: jgarzik@pobox.com
Cc: linux-ide@vger.kernel.org, spear-devel, viresh.linux@gmail.com
On 3/1/2012 1:34 PM, Viresh KUMAR wrote:
> #ifdef, #endif is not required in definition/usage of arasan_cf_pm_ops. So, move
> this definition and its usage outside of them.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
> ---
> drivers/ata/pata_arasan_cf.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
Hi Jeff,
Can you please apply this patch.
--
viresh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ata/pata_arasan_cf: Move arasan_cf_pm_ops out of #ifdef, #endif macros
2012-03-01 8:04 [PATCH] ata/pata_arasan_cf: Move arasan_cf_pm_ops out of #ifdef, #endif macros Viresh Kumar
2012-03-23 8:08 ` Viresh Kumar
@ 2012-04-10 9:32 ` Viresh Kumar
2012-04-12 20:07 ` Jeff Garzik
1 sibling, 1 reply; 5+ messages in thread
From: Viresh Kumar @ 2012-04-10 9:32 UTC (permalink / raw)
To: jgarzik@pobox.com
Cc: linux-ide@vger.kernel.org, spear-devel, viresh.linux@gmail.com
On 3/1/2012 1:34 PM, Viresh KUMAR wrote:
> #ifdef, #endif is not required in definition/usage of arasan_cf_pm_ops. So, move
> this definition and its usage outside of them.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
> ---
> drivers/ata/pata_arasan_cf.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
Hi Jeff,
Can you please apply this patch?
--
viresh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ata/pata_arasan_cf: Move arasan_cf_pm_ops out of #ifdef, #endif macros
2012-04-10 9:32 ` Viresh Kumar
@ 2012-04-12 20:07 ` Jeff Garzik
2012-04-13 3:43 ` Viresh Kumar
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Garzik @ 2012-04-12 20:07 UTC (permalink / raw)
To: Viresh Kumar
Cc: linux-ide@vger.kernel.org, spear-devel, viresh.linux@gmail.com
On 04/10/2012 05:32 AM, Viresh Kumar wrote:
> On 3/1/2012 1:34 PM, Viresh KUMAR wrote:
>> #ifdef, #endif is not required in definition/usage of arasan_cf_pm_ops. So, move
>> this definition and its usage outside of them.
>>
>> Signed-off-by: Viresh Kumar<viresh.kumar@st.com>
>> ---
>> drivers/ata/pata_arasan_cf.c | 4 +---
>> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> Hi Jeff,
>
> Can you please apply this patch?
This has been upstream for a while now.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ata/pata_arasan_cf: Move arasan_cf_pm_ops out of #ifdef, #endif macros
2012-04-12 20:07 ` Jeff Garzik
@ 2012-04-13 3:43 ` Viresh Kumar
0 siblings, 0 replies; 5+ messages in thread
From: Viresh Kumar @ 2012-04-13 3:43 UTC (permalink / raw)
To: Jeff Garzik
Cc: linux-ide@vger.kernel.org, spear-devel, viresh.linux@gmail.com
On 4/13/2012 1:37 AM, Jeff Garzik wrote:
> On 04/10/2012 05:32 AM, Viresh Kumar wrote:
>> On 3/1/2012 1:34 PM, Viresh KUMAR wrote:
>>> #ifdef, #endif is not required in definition/usage of arasan_cf_pm_ops. So, move
>>> this definition and its usage outside of them.
>>>
>>> Signed-off-by: Viresh Kumar<viresh.kumar@st.com>
>>> ---
>>> drivers/ata/pata_arasan_cf.c | 4 +---
>>> 1 files changed, 1 insertions(+), 3 deletions(-)
>>
>> Hi Jeff,
>>
>> Can you please apply this patch?
>
> This has been upstream for a while now.
I couldn't see this in linux-next/master :(
You pushed following patch earlier:
Author: Viresh Kumar <viresh.kumar@st.com>
Date: Thu Feb 23 15:03:53 2012 +0530
ata/pata_arasan_cf: Add Hibernation support
And this one is a fix over it.
--
viresh
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-04-13 3:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-01 8:04 [PATCH] ata/pata_arasan_cf: Move arasan_cf_pm_ops out of #ifdef, #endif macros Viresh Kumar
2012-03-23 8:08 ` Viresh Kumar
2012-04-10 9:32 ` Viresh Kumar
2012-04-12 20:07 ` Jeff Garzik
2012-04-13 3:43 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).