Re: Hotplug borked after suspend/resume in Linux-3.3 ?

[Mark Lord <kernel@teksavvy.com>]

On 12-04-17 04:50 PM, Jeff Garzik wrote:
> On 04/17/2012 04:38 PM, Mark Lord wrote:
>> Okay, so why isn't SATA hotplug working in linux-3.3.2 ?
>> I don't know when it stopped working, but it's a blooming pain in the sysadmin.
>>
>> I need to hotplug a SATA drive into an AHCI port,
>> preferably without having to reboot first.
>>
>> Is there a patch available already for this regression?
> 
> hrm...  smells like runtime PM stuff.
> 
> Can you try "libata: disable runtime pm for hotpluggable port"?
> 
> You probably have to edit ahci_port_pluggable() to make it unconditionally return true.

Okay tried the ahci_port_pluggable() hack, no difference.
The patch above fixes the issue on two systems here with motherboard SATA,
and has zero effect on the AHCI ExpressCard in my notebook.

The notebook issue is definitely PCIe hotplug b0rkage, not libata.
I fixed that once, a few years ago, but it seems to have crept back
into the kernel again when I wasn't paying close attention.

Dunno when, could have been there for ages now.

But the libata regression is new.  And fixable here, at least.
I think whatever broke it should get reverted ASAP until you are
happy with a more permanent solution.

Otherwise the solution above is what I'm now patching into all of my systems here.

Cheers