From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: Hotplug borked after suspend/resume in Linux-3.3 ? Date: Tue, 17 Apr 2012 21:46:50 -0400 Message-ID: <4F8E1D0A.8000203@teksavvy.com> References: <4F8DD4DC.4050503@teksavvy.com> <4F8DD708.8050502@teksavvy.com> <4F8DD939.1050909@pobox.com> <4F8DDB24.9080109@teksavvy.com> <4F8DDC4F.8060103@pobox.com> <4F8DDDC0.2010609@teksavvy.com> <1334712587.11188.139.camel@minggr> <4F8E1ADF.3060606@teksavvy.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from ironport-out.teksavvy.com ([206.248.143.162]:25071 "EHLO ironport-out.teksavvy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752827Ab2DRBqw (ORCPT ); Tue, 17 Apr 2012 21:46:52 -0400 In-Reply-To: <4F8E1ADF.3060606@teksavvy.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Lin Ming Cc: Jeff Garzik , Tejun Heo , linux-ide@vger.kernel.org On 12-04-17 09:37 PM, Mark Lord wrote: > On 12-04-17 09:29 PM, Lin Ming wrote: >> >> I'm working on the hotplug issue fix. >> >> Before the fix is ready, here is the one-line patch. >> Could you give it a try? > .. >> --- a/drivers/ata/libata-transport.c >> +++ b/drivers/ata/libata-transport.c >> @@ -294,6 +294,7 @@ int ata_tport_add(struct device *parent, >> device_enable_async_suspend(dev); >> pm_runtime_set_active(dev); >> pm_runtime_enable(dev); >> + pm_runtime_forbid(dev); >> > .. > > I'm rebuilding the kernel right now.. should take about 5min or less to test. Yeah, that (by itself) is enough to make things work again. This looks like the one-liner that we really need upstream and in -stable. Jeff? I'll now use it instead of the (much larger) "v2 disable runtime pm" thing.