From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org,
Martin Mokrejs <mmokrejs@fold.natur.cuni.cz>
Subject: Re: [PATCH] libata: clear error mask of old error history
Date: Fri, 20 Apr 2012 14:29:20 +0400 [thread overview]
Message-ID: <4F913A80.3030207@mvista.com> (raw)
In-Reply-To: <1334885938.4927.11.camel@minggr>
Hello.
On 20-04-012 5:38, Lin Ming wrote:
> The old error history was cleared in ata_ering_clear().
> It only sets ATA_EFLAG_OLD_ER eflags, but the err_mask was not cleared.
> So ata_ering_map() still iterates the old error history.
> This causes problem, for example, wrong probe trials count were returned in
> ata_eh_schedule_probe(), which in turn causes SATA link speed to be slowed down
> to 1.5Gbps.
> Reported-and-tested-by: Martin Mokrejs<mmokrejs@fold.natur.cuni.cz>
> Signed-off-by: Lin Ming<ming.m.lin@intel.com>
> ---
> Hi Jeff,
> This patch fixes an old regression introduced in 2.6.37-rc1
> of commit d902747.
> So it should be included into stable releases since 2.6.37.
You should have included:
Cc: stable@vger.kernel.org # 2.6.37+
after your signoff in this case.
MBR, Sergei
next prev parent reply other threads:[~2012-04-20 10:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 1:38 [PATCH] libata: clear error mask of old error history Lin Ming
2012-04-20 10:29 ` Sergei Shtylyov [this message]
2012-04-23 1:09 ` Lin Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F913A80.3030207@mvista.com \
--to=sshtylyov@mvista.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mmokrejs@fold.natur.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox