From: Jeff Garzik <jgarzik@pobox.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_artop: use defines from pci.h
Date: Sat, 28 Apr 2012 19:46:13 -0400 [thread overview]
Message-ID: <4F9C8145.50007@pobox.com> (raw)
In-Reply-To: <1335650229-5930-1-git-send-email-vapier@gentoo.org>
On 04/28/2012 05:57 PM, Mike Frysinger wrote:
> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
> ---
> drivers/ata/pata_artop.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/ata/pata_artop.c b/drivers/ata/pata_artop.c
> index 4b8b22e..553a3b3 100644
> --- a/drivers/ata/pata_artop.c
> +++ b/drivers/ata/pata_artop.c
> @@ -414,11 +414,11 @@ static int artop_init_one (struct pci_dev *pdev, const struct pci_device_id *id)
> }
>
> static const struct pci_device_id artop_pci_tbl[] = {
> - { PCI_VDEVICE(ARTOP, 0x0005), 0 },
> - { PCI_VDEVICE(ARTOP, 0x0006), 1 },
> - { PCI_VDEVICE(ARTOP, 0x0007), 1 },
> - { PCI_VDEVICE(ARTOP, 0x0008), 2 },
> - { PCI_VDEVICE(ARTOP, 0x0009), 2 },
> + { PCI_VDEVICE(ARTOP, PCI_DEVICE_ID_ARTOP_ATP850UF), 0 },
> + { PCI_VDEVICE(ARTOP, PCI_DEVICE_ID_ARTOP_ATP860), 1 },
> + { PCI_VDEVICE(ARTOP, PCI_DEVICE_ID_ARTOP_ATP860R), 1 },
> + { PCI_VDEVICE(ARTOP, PCI_DEVICE_ID_ARTOP_ATP865), 2 },
> + { PCI_VDEVICE(ARTOP, PCI_DEVICE_ID_ARTOP_ATP865R), 2 },
This is going in the reverse direction of where we want to go. The
device IDs are largely arbitrary even at the vendor level, and these PCI
symbols are often only used in a single location (the driver itself).
Better to delete these PCI_DEVICE_ID_ARTOP_xxx symbols instead.
Jeff
prev parent reply other threads:[~2012-04-28 23:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 21:57 [PATCH] pata_artop: use defines from pci.h Mike Frysinger
2012-04-28 23:46 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9C8145.50007@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).