* [PATCH] pata_artop: use defines from pci.h
@ 2012-04-28 21:57 Mike Frysinger
2012-04-28 23:46 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2012-04-28 21:57 UTC (permalink / raw)
To: linux-ide, Jeff Garzik
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
drivers/ata/pata_artop.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/ata/pata_artop.c b/drivers/ata/pata_artop.c
index 4b8b22e..553a3b3 100644
--- a/drivers/ata/pata_artop.c
+++ b/drivers/ata/pata_artop.c
@@ -414,11 +414,11 @@ static int artop_init_one (struct pci_dev *pdev, const struct pci_device_id *id)
}
static const struct pci_device_id artop_pci_tbl[] = {
- { PCI_VDEVICE(ARTOP, 0x0005), 0 },
- { PCI_VDEVICE(ARTOP, 0x0006), 1 },
- { PCI_VDEVICE(ARTOP, 0x0007), 1 },
- { PCI_VDEVICE(ARTOP, 0x0008), 2 },
- { PCI_VDEVICE(ARTOP, 0x0009), 2 },
+ { PCI_VDEVICE(ARTOP, PCI_DEVICE_ID_ARTOP_ATP850UF), 0 },
+ { PCI_VDEVICE(ARTOP, PCI_DEVICE_ID_ARTOP_ATP860), 1 },
+ { PCI_VDEVICE(ARTOP, PCI_DEVICE_ID_ARTOP_ATP860R), 1 },
+ { PCI_VDEVICE(ARTOP, PCI_DEVICE_ID_ARTOP_ATP865), 2 },
+ { PCI_VDEVICE(ARTOP, PCI_DEVICE_ID_ARTOP_ATP865R), 2 },
{ } /* terminate list */
};
--
1.7.9.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pata_artop: use defines from pci.h
2012-04-28 21:57 [PATCH] pata_artop: use defines from pci.h Mike Frysinger
@ 2012-04-28 23:46 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2012-04-28 23:46 UTC (permalink / raw)
To: Mike Frysinger; +Cc: linux-ide
On 04/28/2012 05:57 PM, Mike Frysinger wrote:
> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
> ---
> drivers/ata/pata_artop.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/ata/pata_artop.c b/drivers/ata/pata_artop.c
> index 4b8b22e..553a3b3 100644
> --- a/drivers/ata/pata_artop.c
> +++ b/drivers/ata/pata_artop.c
> @@ -414,11 +414,11 @@ static int artop_init_one (struct pci_dev *pdev, const struct pci_device_id *id)
> }
>
> static const struct pci_device_id artop_pci_tbl[] = {
> - { PCI_VDEVICE(ARTOP, 0x0005), 0 },
> - { PCI_VDEVICE(ARTOP, 0x0006), 1 },
> - { PCI_VDEVICE(ARTOP, 0x0007), 1 },
> - { PCI_VDEVICE(ARTOP, 0x0008), 2 },
> - { PCI_VDEVICE(ARTOP, 0x0009), 2 },
> + { PCI_VDEVICE(ARTOP, PCI_DEVICE_ID_ARTOP_ATP850UF), 0 },
> + { PCI_VDEVICE(ARTOP, PCI_DEVICE_ID_ARTOP_ATP860), 1 },
> + { PCI_VDEVICE(ARTOP, PCI_DEVICE_ID_ARTOP_ATP860R), 1 },
> + { PCI_VDEVICE(ARTOP, PCI_DEVICE_ID_ARTOP_ATP865), 2 },
> + { PCI_VDEVICE(ARTOP, PCI_DEVICE_ID_ARTOP_ATP865R), 2 },
This is going in the reverse direction of where we want to go. The
device IDs are largely arbitrary even at the vendor level, and these PCI
symbols are often only used in a single location (the driver itself).
Better to delete these PCI_DEVICE_ID_ARTOP_xxx symbols instead.
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-28 23:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-28 21:57 [PATCH] pata_artop: use defines from pci.h Mike Frysinger
2012-04-28 23:46 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).