From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org,
Martin Mokrejs <mmokrejs@fold.natur.cuni.cz>,
Grant Grundler <grundler@google.com>,
Gwendal Grignou <gwendal@google.com>
Subject: Re: [PATCH] libata: skip old error history when counting probe trials
Date: Thu, 03 May 2012 15:10:18 +0400 [thread overview]
Message-ID: <4FA2679A.2040504@mvista.com> (raw)
In-Reply-To: <1336008189.5520.25.camel@minggr>
Hello.
On 03-05-2012 5:23, Lin Ming wrote:
> Commit d902747
Please also specify the summary of that commit in parens.
> introduced ATA_EFLAG_OLD_ER to mark entries in the
> error ring as cleared.
> But ata_count_probe_trials_cb() didn't check this flag and it still
> counts the old error history. So wrong probe trials count is returned
> and it causes problem, for example, SATA link speed is slowed down from
> 3.0Gbps to 1.5Gbps.
> Fix it by checking ATA_EFLAG_OLD_ER in ata_count_probe_trials_cb().
> Cc: stable<stable@vger.kernel.org> # 2.6.37+
> Signed-off-by: Lin Ming<ming.m.lin@intel.com>
MBR, Sergei
next prev parent reply other threads:[~2012-05-03 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 1:23 [PATCH] libata: skip old error history when counting probe trials Lin Ming
2012-05-03 11:10 ` Sergei Shtylyov [this message]
2012-05-03 14:15 ` Lin Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA2679A.2040504@mvista.com \
--to=sshtylyov@mvista.com \
--cc=grundler@google.com \
--cc=gwendal@google.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mmokrejs@fold.natur.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox