Re: [PATCH 2/3] ata: libata-core: Quirk DELLBOSS VD MV.R00-0 max_sectors

[Damien Le Moal <dlemoal@kernel.org>]

On 11/24/25 10:44 PM, Niklas Cassel wrote:
> DELLBOSS VD MV.R00-0 with FW rev MV.R00-0 times out when sending
> I/Os of size 4096 KiB.
> 
> Add a quirk so that the SATA controller is usable again.

Please name the quirk here and describe it.

> 
> Fixes: 9b8b84879d4a ("block: Increase BLK_DEF_MAX_SECTORS_CAP")
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> ---
>  drivers/ata/libata-core.c | 12 ++++++++++++
>  include/linux/ata.h       |  1 +
>  include/linux/libata.h    |  2 ++
>  3 files changed, 15 insertions(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index f48fb63d7e85..be320c3e0fef 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -3146,6 +3146,10 @@ int ata_dev_configure(struct ata_device *dev)
>  		dev->max_sectors = min_t(unsigned int, ATA_MAX_SECTORS_1024,
>  					 dev->max_sectors);
>  
> +	if (dev->quirks & ATA_QUIRK_MAX_SEC_8191)
> +		dev->max_sectors = min_t(unsigned int, ATA_MAX_SECTORS_8191,
> +					 dev->max_sectors);
> +
>  	if (dev->quirks & ATA_QUIRK_MAX_SEC_LBA48)
>  		dev->max_sectors = ATA_MAX_SECTORS_LBA48;
>  
> @@ -3998,6 +4002,7 @@ static const char * const ata_quirk_names[] = {
>  	[__ATA_QUIRK_NO_DMA_LOG]	= "nodmalog",
>  	[__ATA_QUIRK_NOTRIM]		= "notrim",
>  	[__ATA_QUIRK_MAX_SEC_1024]	= "maxsec1024",
> +	[__ATA_QUIRK_MAX_SEC_8191]	= "maxsec8191",

It would be a lot better  if we could have a definition for this a little more
generic, that is, add a value to a generic "maxsec" quirk. E.g.:
 	
	[__ATA_QUIRK_MAX_SEC_8191]	= { "maxsec", 8191 },

That would avoid the need for more of these if other drives have different
limits. We already have 2 maxsec limit, this is the 3rd one...

>  	[__ATA_QUIRK_MAX_TRIM_128M]	= "maxtrim128m",
>  	[__ATA_QUIRK_NO_NCQ_ON_ATI]	= "noncqonati",
>  	[__ATA_QUIRK_NO_LPM_ON_ATI]	= "nolpmonati",
> @@ -4104,6 +4109,12 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
>  	{ "LITEON CX1-JB*-HP",	NULL,		ATA_QUIRK_MAX_SEC_1024 },
>  	{ "LITEON EP1-*",	NULL,		ATA_QUIRK_MAX_SEC_1024 },
>  
> +	/*
> +	 * These devices time out with higher max sects.
> +	 * https://bugzilla.kernel.org/show_bug.cgi?id=220693
> +	 */
> +	{ "DELLBOSS VD MV.R00-0", "MV.R00-0",	ATA_QUIRK_MAX_SEC_8191 },
> +
>  	/* Devices we expect to fail diagnostics */
>  
>  	/* Devices where NCQ should be avoided */
> @@ -6455,6 +6466,7 @@ static const struct ata_force_param force_tbl[] __initconst = {
>  
>  	force_quirk_on(max_sec_128,	ATA_QUIRK_MAX_SEC_128),
>  	force_quirk_on(max_sec_1024,	ATA_QUIRK_MAX_SEC_1024),
> +	force_quirk_on(max_sec_8191,	ATA_QUIRK_MAX_SEC_8191),
>  	force_quirk_on(max_sec_lba48,	ATA_QUIRK_MAX_SEC_LBA48),
>  
>  	force_quirk_onoff(lpm,		ATA_QUIRK_NOLPM),
> diff --git a/include/linux/ata.h b/include/linux/ata.h
> index c9013e472aa3..54b416e26995 100644
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
> @@ -29,6 +29,7 @@ enum {
>  	ATA_MAX_SECTORS_128	= 128,
>  	ATA_MAX_SECTORS		= 256,
>  	ATA_MAX_SECTORS_1024    = 1024,
> +	ATA_MAX_SECTORS_8191    = 8191,
>  	ATA_MAX_SECTORS_LBA48	= 65535,/* avoid count to be 0000h */
>  	ATA_MAX_SECTORS_TAPE	= 65535,
>  	ATA_MAX_TRIM_RNUM	= 64,	/* 512-byte payload / (6-byte LBA + 2-byte range per entry) */
> diff --git a/include/linux/libata.h b/include/linux/libata.h
> index 171268d65169..39534fafa36a 100644
> --- a/include/linux/libata.h
> +++ b/include/linux/libata.h
> @@ -75,6 +75,7 @@ enum ata_quirks {
>  	__ATA_QUIRK_NO_DMA_LOG,		/* Do not use DMA for log read */
>  	__ATA_QUIRK_NOTRIM,		/* Do not use TRIM */
>  	__ATA_QUIRK_MAX_SEC_1024,	/* Limit max sects to 1024 */
> +	__ATA_QUIRK_MAX_SEC_8191,	/* Limit max sects to 8191 */
>  	__ATA_QUIRK_MAX_TRIM_128M,	/* Limit max trim size to 128M */
>  	__ATA_QUIRK_NO_NCQ_ON_ATI,	/* Disable NCQ on ATI chipset */
>  	__ATA_QUIRK_NO_LPM_ON_ATI,	/* Disable LPM on ATI chipset */
> @@ -115,6 +116,7 @@ enum {
>  	ATA_QUIRK_NO_DMA_LOG		= (1U << __ATA_QUIRK_NO_DMA_LOG),
>  	ATA_QUIRK_NOTRIM		= (1U << __ATA_QUIRK_NOTRIM),
>  	ATA_QUIRK_MAX_SEC_1024		= (1U << __ATA_QUIRK_MAX_SEC_1024),
> +	ATA_QUIRK_MAX_SEC_8191		= (1U << __ATA_QUIRK_MAX_SEC_8191),
>  	ATA_QUIRK_MAX_TRIM_128M		= (1U << __ATA_QUIRK_MAX_TRIM_128M),
>  	ATA_QUIRK_NO_NCQ_ON_ATI		= (1U << __ATA_QUIRK_NO_NCQ_ON_ATI),
>  	ATA_QUIRK_NO_LPM_ON_ATI		= (1U << __ATA_QUIRK_NO_LPM_ON_ATI),


-- 
Damien Le Moal
Western Digital Research