From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A162C433F5 for ; Wed, 2 Feb 2022 23:06:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347989AbiBBXGB (ORCPT ); Wed, 2 Feb 2022 18:06:01 -0500 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:37044 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242772AbiBBXGB (ORCPT ); Wed, 2 Feb 2022 18:06:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1643843161; x=1675379161; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=NGAPUIaEsO3aMi4Qi5/6U7okQHSqH+e13bpfc7DdLHM=; b=Om55cxOhZoMOsX1+inf95VgrqQ+rO9FMHYD0GXr62oSczXHFdEPJaHgd SboPvlizzQKwFBtjmXHmnYf7CgacD09wWJKV3B0pmhFELxBLtz5c8yQsb O8uMoxWl362tvKhQITcG0250bTDMASHaEM2RvoiqN48iJO5DBuOf/EYhy lGyn4KL4DBwGK7jzRAUqLl9du3/RnUn3tadOVELdUn8ISMFbaGWfH8L4z goc4Tmnr2MdVMPXM4JS1ZRhAAUpIFUSsubpMH4ojiM0+ztqIZWPJgf/in 1FkYhxYJcaQAGe6arGLIFQr3PTqZaJQp5s1F8kcSdcfW1n4/WqgrCXMo+ Q==; X-IronPort-AV: E=Sophos;i="5.88,338,1635177600"; d="scan'208";a="303919052" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 03 Feb 2022 07:06:00 +0800 IronPort-SDR: OhwpYeOYQ7xpw1KMt0Lsxh4fFN9UnLEmERHPwZtnak/xKmvM75Ga2IQAoAttTTQ4U8WrvG3j3T Q2VN0/6kfuTFd2QFWxgeHFWHeb4Am+JbgG1EfqhvJGpL+Mrt/s9qbFpVZ+sZI1nYdkpaHzpmOD +uqqo0htPLEvetxFFzLxdCRDqSDaJHL/KiM3sgrRLwEWiPOFfinPEjvXzS2QsM9SgVS7nOlXMr 3Dcz8qBHGEjZnfdrmuYzlRKim6/ZQpX0pSQA7h55qzDDywLlhlD+ImsKtDHcs82pVuLKw1zInD XsefTHUzYkgYgxqy9FppJJFr Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2022 14:37:56 -0800 IronPort-SDR: yruR7rpPABXatIGhbku8JyTuk1s4b+nEFNnrk0oODSTB4bxvBVPQPOGzU2XtTTsKR0qjmwckVY 4tY4wAUADgnKbwx2nZI/5YkZmhwxOoK7mWRhphPBWG9mepvwax09j67jagquTCP6k/tGkOyCbh xAZBkS6df0WTr5XCmov6YVHFOw/ccSX0QsLUfEnN/mlgbzc+hoF86EvE0zhGl9Ar/HmzCt4rnW Im4R+BMOdYx98sVowTCLTOAXSCROsfRqghtsp1sFWv6X1hNlLB7TIB1ctknBO9eMD7vPpN4BU6 Z6E= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2022 15:06:00 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Jpy8S320lz1SVnx for ; Wed, 2 Feb 2022 15:06:00 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1643843159; x=1646435160; bh=NGAPUIaEsO3aMi4Qi5/6U7okQHSqH+e13bp fc7DdLHM=; b=T2WRjO8jFsM0d6WAw6j+K089ZivmZP60rhxzCa/1QKnsZNPJmvk YDr4aayWMeam1/KeSt8IZ7t58IrliJtiz9MGXG2UdrsWWsN5VOPmODKXO2ziFZJi qXtDjqYeNJLVxSRiSEpKv+t34pb9rPd6M03ggP7aWyTmB7iD+hcG6Z3AJTns9wLe Rm+L61VOBB7saR8frGcz2awuqtbt4qft4iH15QNGLUj2Z6d2sWP5SiA67mWDCS8u EUKQHM7k8DiEcZ9BOv2TYkT5HSRN+MNW0UDIkTc34QYmx8f/HNta/X+hrnj0U+NS jPNbQXz9UfIhIF9vhzjuNxISaiqyeD3mYIQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id I4jLmrP1IvRM for ; Wed, 2 Feb 2022 15:05:59 -0800 (PST) Received: from [10.225.163.63] (unknown [10.225.163.63]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Jpy8R2fB7z1Rwrw; Wed, 2 Feb 2022 15:05:59 -0800 (PST) Message-ID: <4c3df325-dc9f-5eed-5585-7d2e5203b65f@opensource.wdc.com> Date: Thu, 3 Feb 2022 08:05:57 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3] ata: ahci: Skip 200 ms debounce delay for Marvell 88SE9235 Content-Language: en-US To: Paul Menzel Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220201071229.6418-1-pmenzel@molgen.mpg.de> <3437ffcb-68b5-04e5-acd5-b3857fbf1be7@opensource.wdc.com> <1378dd0a-52d2-c998-5713-e6875c601194@molgen.mpg.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <1378dd0a-52d2-c998-5713-e6875c601194@molgen.mpg.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 2/2/22 23:29, Paul Menzel wrote: > Dear Damien, >=20 >=20 > Am 02.02.22 um 09:14 schrieb Damien Le Moal: >> On 2/1/22 16:12, Paul Menzel wrote: >>> The 200 ms delay before debouncing the PHY in `sata_link_resume()` is >>> not needed for the Marvell 88SE9235. >>> >>> $ lspci -nn -s 0021:0e:00.0 >>> 0021:0e:00.0 SATA controller [0106]: Marvell Technology Group Lt= d. 88SE9235 PCIe 2.0 x2 4-port SATA 6 Gb/s Controller [1b4b:9235] (rev 11= ) >>> >>> So, remove it. Tested on IBM S822LC with current Linux 5.17-rc1: >>> >>> Currently, without this patch (with 200 ms delay), device probe for a= ta1 >>> takes 485 ms: >>> >>> [ 3.358158] ata1: SATA max UDMA/133 abar m2048@0x3fe881000000= port 0x3fe881000100 irq 39 >>> [ 3.358175] ata2: SATA max UDMA/133 abar m2048@0x3fe881000000= port 0x3fe881000180 irq 39 >>> [ 3.358191] ata3: SATA max UDMA/133 abar m2048@0x3fe881000000= port 0x3fe881000200 irq 39 >>> [ 3.358207] ata4: SATA max UDMA/133 abar m2048@0x3fe881000000= port 0x3fe881000280 irq 39 >>> [=E2=80=A6] >>> [ 3.677542] ata3: SATA link down (SStatus 0 SControl 300) >>> [ 3.677719] ata4: SATA link down (SStatus 0 SControl 300) >>> [ 3.839242] ata2: SATA link up 6.0 Gbps (SStatus 133 SControl= 300) >>> [ 3.839828] ata2.00: ATA-10: ST1000NX0313 00LY266 00L= Y265IBM, BE33, max UDMA/133 >>> [ 3.840029] ata2.00: 1953525168 sectors, multi 0: LBA48 NCQ (= depth 32), AA >>> [ 3.841796] ata2.00: configured for UDMA/133 >>> [ 3.843231] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl= 300) >>> [ 3.844083] ata1.00: ATA-10: ST1000NX0313 00LY266 00L= Y265IBM, BE33, max UDMA/133 >>> [ 3.844313] ata1.00: 1953525168 sectors, multi 0: LBA48 NCQ (= depth 32), AA >>> [ 3.846043] ata1.00: configured for UDMA/133 >>> >>> With this patch (no delay) device probe for ata1 takes 273 ms: >>> >>> [ 3.624259] ata1: SATA max UDMA/133 abar m2048@0x3fe881000000= port 0x3f e881000100 irq 39 >>> [ 3.624436] ata2: SATA max UDMA/133 abar m2048@0x3fe881000000= port 0x3f e881000180 irq 39 >>> [ 3.624452] ata3: SATA max UDMA/133 abar m2048@0x3fe881000000= port 0x3f e881000200 irq 39 >>> [ 3.624468] ata4: SATA max UDMA/133 abar m2048@0x3fe881000000= port 0x3f e881000280 irq 39 >>> [=E2=80=A6] >>> [ 3.731966] ata3: SATA link down (SStatus 0 SControl 300) >>> [ 3.732069] ata4: SATA link down (SStatus 0 SControl 300) >>> [ 3.897448] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl= 300) >>> [ 3.897678] ata2: SATA link up 6.0 Gbps (SStatus 133 SControl= 300) >>> [ 3.898140] ata1.00: ATA-10: ST1000NX0313 00LY266 00L= Y265IBM, BE33, max UDMA/133 >>> [ 3.898175] ata2.00: ATA-10: ST1000NX0313 00LY266 00L= Y265IBM, BE33, max UDMA/133 >>> [ 3.898287] ata1.00: 1953525168 sectors, multi 0: LBA48 NCQ (= depth 32), AA >>> [ 3.898349] ata2.00: 1953525168 sectors, multi 0: LBA48 NCQ (= depth 32), AA >>> [ 3.900070] ata1.00: configured for UDMA/133 >>> [ 3.900166] ata2.00: configured for UDMA/133 >>> >>> Signed-off-by: Paul Menzel >>> --- >>> v2: address comments for commit message (but forgot v2 tag) >>> v3: resend with v3 tag in subject line/commit message summary >>> >>> drivers/ata/ahci.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c >>> index ab5811ef5a53..edca4e8fd44e 100644 >>> --- a/drivers/ata/ahci.c >>> +++ b/drivers/ata/ahci.c >>> @@ -582,6 +582,8 @@ static const struct pci_device_id ahci_pci_tbl[] = =3D { >>> .driver_data =3D board_ahci_yes_fbs }, >>> { PCI_DEVICE(PCI_VENDOR_ID_MARVELL_EXT, 0x9230), >>> .driver_data =3D board_ahci_yes_fbs }, >>> + { PCI_DEVICE(PCI_VENDOR_ID_MARVELL_EXT, 0x9235), >>> + .driver_data =3D board_ahci_no_debounce_delay }, >>> { PCI_DEVICE(PCI_VENDOR_ID_TTI, 0x0642), /* highpoint rocketraid 6= 42L */ >>> .driver_data =3D board_ahci_yes_fbs }, >>> { PCI_DEVICE(PCI_VENDOR_ID_TTI, 0x0645), /* highpoint rocketraid 6= 44L */ >> >> Applied to for-5.18 with commit title and message changes. The title i= s now: >> >> ata: ahci: Add support for Marvell 88SE9235 adapter >> >> Since it is exactly what this patch is doing by adding a PCI ID. >=20 > Thank you for applying the patch. I saw the summary/title change also=20 > with the other patch. I am sorry, but I totally disagree. Reading that=20 > summary/title in `git log --oneline`, it=E2=80=99s not clear at all, wh= at the=20 > patch does, and the full description or diff has to be read. =E2=80=9CA= dd=20 > support=E2=80=9D for me means, that it was unsupported before, which is= not true=20 > at all as the defaults were used. Right... I did not consider the final entry in the ahci_pci_tbl table which matches against the device against the PCI AHCI storage class. So right you are. I will restore your original commit title/message. Thanks for checking. --=20 Damien Le Moal Western Digital Research