From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: linux-pm@vger.kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 04/10] ata: ahci: Use `pm_suspend_preferred_s2idle`
Date: Fri, 1 Jul 2022 14:06:18 +0900 [thread overview]
Message-ID: <4e0783ac-b9f5-24ff-f7c6-7b64549b8f9c@opensource.wdc.com> (raw)
In-Reply-To: <20220701023328.2783-4-mario.limonciello@amd.com>
On 7/1/22 11:33, Mario Limonciello wrote:
> Drop the direct check from the FADT and use the helper instead.
Where is this helper defined ? Seeing that this is patch 4/10, I have no
context for this patch. Please send the whole series next time.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/ata/ahci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index c1eca72b4575..3f79b732dd00 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1611,7 +1611,7 @@ static void ahci_update_initial_lpm_policy(struct ata_port *ap,
>
> #ifdef CONFIG_ACPI
> if (policy > ATA_LPM_MED_POWER &&
> - (acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0)) {
> + pm_suspend_preferred_s2idle()) {
> if (hpriv->cap & HOST_CAP_PART)
> policy = ATA_LPM_MIN_POWER_WITH_PARTIAL;
> else if (hpriv->cap & HOST_CAP_SSC)
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2022-07-01 5:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220701023328.2783-1-mario.limonciello@amd.com>
2022-07-01 2:33 ` [PATCH v3 04/10] ata: ahci: Use `pm_suspend_preferred_s2idle` Mario Limonciello
2022-07-01 5:06 ` Damien Le Moal [this message]
2022-07-01 18:01 ` Mario Limonciello
2022-07-02 9:34 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e0783ac-b9f5-24ff-f7c6-7b64549b8f9c@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox