* [PATCH] sata_fsl: build fix [not found] <CGME20200325151525eucas1p1870a02b81ef13a8e449b0dfbabd0fe81@eucas1p1.samsung.com> @ 2020-03-25 15:15 ` Bartlomiej Zolnierkiewicz 2020-03-25 15:17 ` Jens Axboe 0 siblings, 1 reply; 5+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2020-03-25 15:15 UTC (permalink / raw) To: Jens Axboe Cc: Guenter Roeck, Hannes Reinecke, Tejun Heo, linux-ide, b.zolnierkie Fix incorrect DPRINTK() conversion in sata_fsl_init_controller() (dev_dbg() should be used instead of ata_port_dbg()). Fixes: b3f062310706 ("sata_fsl: move DPRINTK to ata debugging") Reported-by: Guenter Roeck <linux@roeck-us.net> Reported-by: kbuild test robot <lkp@intel.com> Cc: Hannes Reinecke <hare@suse.de> Cc: Tejun Heo <tj@kernel.org> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> --- drivers/ata/sata_fsl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ata/sata_fsl.c =================================================================== --- a/drivers/ata/sata_fsl.c +++ b/drivers/ata/sata_fsl.c @@ -1362,7 +1362,7 @@ static int sata_fsl_init_controller(stru iowrite32((temp & ~0x3F), hcr_base + HCONTROL); /* Disable interrupt coalescing control(icc), for the moment */ - ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC)); + dev_dbg(host->dev, "icc = 0x%x\n", ioread32(hcr_base + ICC)); iowrite32(0x01000000, hcr_base + ICC); /* clear error registers, SError is cleared by libATA */ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sata_fsl: build fix 2020-03-25 15:15 ` [PATCH] sata_fsl: build fix Bartlomiej Zolnierkiewicz @ 2020-03-25 15:17 ` Jens Axboe 2020-03-25 16:25 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 5+ messages in thread From: Jens Axboe @ 2020-03-25 15:17 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: Guenter Roeck, Hannes Reinecke, Tejun Heo, linux-ide On 3/25/20 9:15 AM, Bartlomiej Zolnierkiewicz wrote: > Fix incorrect DPRINTK() conversion in sata_fsl_init_controller() > (dev_dbg() should be used instead of ata_port_dbg()). Thanks Bart, another piece of fallout. Applied. With the recent discussion as well, I wonder if we should just kill this series entirely. -- Jens Axboe ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sata_fsl: build fix 2020-03-25 15:17 ` Jens Axboe @ 2020-03-25 16:25 ` Bartlomiej Zolnierkiewicz 2020-03-25 16:31 ` Jens Axboe 2020-03-25 17:01 ` Hannes Reinecke 0 siblings, 2 replies; 5+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2020-03-25 16:25 UTC (permalink / raw) To: Jens Axboe; +Cc: Guenter Roeck, Hannes Reinecke, Tejun Heo, linux-ide On 3/25/20 4:17 PM, Jens Axboe wrote: > On 3/25/20 9:15 AM, Bartlomiej Zolnierkiewicz wrote: >> Fix incorrect DPRINTK() conversion in sata_fsl_init_controller() >> (dev_dbg() should be used instead of ata_port_dbg()). > > Thanks Bart, another piece of fallout. Applied. > > With the recent discussion as well, I wonder if we should just kill > this series entirely. I hate to admit it but probably yes.. It seems that the one of base concepts needs to be redesigned and we are at -rc7 so it is a bit too late do it now.. I've also tried to find a way to revert it partially but changes are inter-dependent and it doesn't seem to be easy way to do it.. Hannes? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sata_fsl: build fix 2020-03-25 16:25 ` Bartlomiej Zolnierkiewicz @ 2020-03-25 16:31 ` Jens Axboe 2020-03-25 17:01 ` Hannes Reinecke 1 sibling, 0 replies; 5+ messages in thread From: Jens Axboe @ 2020-03-25 16:31 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: Guenter Roeck, Hannes Reinecke, Tejun Heo, linux-ide On 3/25/20 10:25 AM, Bartlomiej Zolnierkiewicz wrote: > > On 3/25/20 4:17 PM, Jens Axboe wrote: >> On 3/25/20 9:15 AM, Bartlomiej Zolnierkiewicz wrote: >>> Fix incorrect DPRINTK() conversion in sata_fsl_init_controller() >>> (dev_dbg() should be used instead of ata_port_dbg()). >> >> Thanks Bart, another piece of fallout. Applied. >> >> With the recent discussion as well, I wonder if we should just kill >> this series entirely. > I hate to admit it but probably yes.. > > It seems that the one of base concepts needs to be redesigned and > we are at -rc7 so it is a bit too late do it now.. > > I've also tried to find a way to revert it partially but changes are > inter-dependent and it doesn't seem to be easy way to do it.. > > Hannes? I've killed it, we can always try again later, if we have to. -- Jens Axboe ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sata_fsl: build fix 2020-03-25 16:25 ` Bartlomiej Zolnierkiewicz 2020-03-25 16:31 ` Jens Axboe @ 2020-03-25 17:01 ` Hannes Reinecke 1 sibling, 0 replies; 5+ messages in thread From: Hannes Reinecke @ 2020-03-25 17:01 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz, Jens Axboe; +Cc: Guenter Roeck, Tejun Heo, linux-ide On 3/25/20 5:25 PM, Bartlomiej Zolnierkiewicz wrote: > > On 3/25/20 4:17 PM, Jens Axboe wrote: >> On 3/25/20 9:15 AM, Bartlomiej Zolnierkiewicz wrote: >>> Fix incorrect DPRINTK() conversion in sata_fsl_init_controller() >>> (dev_dbg() should be used instead of ata_port_dbg()). >> >> Thanks Bart, another piece of fallout. Applied. >> >> With the recent discussion as well, I wonder if we should just kill >> this series entirely. > I hate to admit it but probably yes.. > > It seems that the one of base concepts needs to be redesigned and > we are at -rc7 so it is a bit too late do it now.. > > I've also tried to find a way to revert it partially but changes are > inter-dependent and it doesn't seem to be easy way to do it.. > > Hannes? > Seeing that we are late in the game and the dev_printk() fallacies are indeed there I fear that you are correct. Jens, again, sorry for the mess. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-25 17:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20200325151525eucas1p1870a02b81ef13a8e449b0dfbabd0fe81@eucas1p1.samsung.com>
2020-03-25 15:15 ` [PATCH] sata_fsl: build fix Bartlomiej Zolnierkiewicz
2020-03-25 15:17 ` Jens Axboe
2020-03-25 16:25 ` Bartlomiej Zolnierkiewicz
2020-03-25 16:31 ` Jens Axboe
2020-03-25 17:01 ` Hannes Reinecke
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox