linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: linux-next: Tree for Sept 14 (sata_highhbank)
       [not found] <20120914173813.fa65528e5236bd0a20c29b92@canb.auug.org.au>
@ 2012-09-14 17:04 ` Randy Dunlap
  2012-09-14 22:02   ` Mark Langsdorf
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2012-09-14 17:04 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, LKML, linux-ide, Mark Langsdorf

On 09/14/2012 12:38 AM, Stephen Rothwell wrote:

> Hi all,
> 
> Changes since 201209013:
> 



on i386:

CONFIG_SATA_HIGHBANK=m
# CONFIG_SATA_AHCI_PLATFORM is not set

ERROR: "ahci_sdev_attrs" [drivers/ata/sata_highbank.ko] undefined!
ERROR: "ahci_shost_attrs" [drivers/ata/sata_highbank.ko] undefined!
ERROR: "ahci_ops" [drivers/ata/sata_highbank.ko] undefined!
ERROR: "ahci_dev_classify" [drivers/ata/sata_highbank.ko] undefined!
ERROR: "ahci_start_engine" [drivers/ata/sata_highbank.ko] undefined!
ERROR: "ahci_stop_engine" [drivers/ata/sata_highbank.ko] undefined!
ERROR: "ahci_interrupt" [drivers/ata/sata_highbank.ko] undefined!
ERROR: "ahci_print_info" [drivers/ata/sata_highbank.ko] undefined!
ERROR: "ahci_reset_em" [drivers/ata/sata_highbank.ko] undefined!
ERROR: "ahci_ignore_sss" [drivers/ata/sata_highbank.ko] undefined!
ERROR: "ahci_set_em_messages" [drivers/ata/sata_highbank.ko] undefined!
ERROR: "ahci_save_initial_config" [drivers/ata/sata_highbank.ko] undefined!
ERROR: "ahci_init_controller" [drivers/ata/sata_highbank.ko] undefined!
ERROR: "ahci_reset_controller" [drivers/ata/sata_highbank.ko] undefined!

-- 
~Randy

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: linux-next: Tree for Sept 14 (sata_highhbank)
  2012-09-14 17:04 ` linux-next: Tree for Sept 14 (sata_highhbank) Randy Dunlap
@ 2012-09-14 22:02   ` Mark Langsdorf
  2012-09-14 22:17     ` Jeff Garzik
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Langsdorf @ 2012-09-14 22:02 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Stephen Rothwell, linux-next@vger.kernel.org, LKML,
	linux-ide@vger.kernel.org

On 09/14/2012 12:04 PM, Randy Dunlap wrote:
> On 09/14/2012 12:38 AM, Stephen Rothwell wrote:
> 
>> Hi all,
>>
>> Changes since 201209013:
>>
> 
> 
> 
> on i386:
> 
> CONFIG_SATA_HIGHBANK=m
> # CONFIG_SATA_AHCI_PLATFORM is not set
> 
> ERROR: "ahci_sdev_attrs" [drivers/ata/sata_highbank.ko] undefined!
> ERROR: "ahci_shost_attrs" [drivers/ata/sata_highbank.ko] undefined!
> ERROR: "ahci_ops" [drivers/ata/sata_highbank.ko] undefined!
> ERROR: "ahci_dev_classify" [drivers/ata/sata_highbank.ko] undefined!
> ERROR: "ahci_start_engine" [drivers/ata/sata_highbank.ko] undefined!
> ERROR: "ahci_stop_engine" [drivers/ata/sata_highbank.ko] undefined!
> ERROR: "ahci_interrupt" [drivers/ata/sata_highbank.ko] undefined!
> ERROR: "ahci_print_info" [drivers/ata/sata_highbank.ko] undefined!
> ERROR: "ahci_reset_em" [drivers/ata/sata_highbank.ko] undefined!
> ERROR: "ahci_ignore_sss" [drivers/ata/sata_highbank.ko] undefined!
> ERROR: "ahci_set_em_messages" [drivers/ata/sata_highbank.ko] undefined!
> ERROR: "ahci_save_initial_config" [drivers/ata/sata_highbank.ko] undefined!
> ERROR: "ahci_init_controller" [drivers/ata/sata_highbank.ko] undefined!
> ERROR: "ahci_reset_controller" [drivers/ata/sata_highbank.ko] undefined!
> 
Fix patch follows. Do I need to submit it as a separate patch or is this
sufficient?

--Mark Langsdorf
Calxeda, Inc.

[PATCH] ata: fix compile error for sata_highbank

sata_highbank depends on the libahci library.

Signed-off-by: Mark Langsdorf <mark.langsdorf@calxeda.com>
---
 drivers/ata/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index 8b384f1..9329daf 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -9,7 +9,7 @@ obj-$(CONFIG_SATA_FSL)		+= sata_fsl.o
 obj-$(CONFIG_SATA_INIC162X)	+= sata_inic162x.o
 obj-$(CONFIG_SATA_SIL24)	+= sata_sil24.o
 obj-$(CONFIG_SATA_DWC)		+= sata_dwc_460ex.o
-obj-$(CONFIG_SATA_HIGHBANK)	+= sata_highbank.o
+obj-$(CONFIG_SATA_HIGHBANK)	+= sata_highbank.o libahci.o

 # SFF w/ custom DMA
 obj-$(CONFIG_PDC_ADMA)		+= pdc_adma.o
-- 
1.7.5.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: linux-next: Tree for Sept 14 (sata_highhbank)
  2012-09-14 22:02   ` Mark Langsdorf
@ 2012-09-14 22:17     ` Jeff Garzik
  0 siblings, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2012-09-14 22:17 UTC (permalink / raw)
  To: Mark Langsdorf
  Cc: Randy Dunlap, Stephen Rothwell, linux-next@vger.kernel.org, LKML,
	linux-ide@vger.kernel.org

On Fri, Sep 14, 2012 at 11:02 PM, Mark Langsdorf
<mark.langsdorf@calxeda.com> wrote:
> Fix patch follows. Do I need to submit it as a separate patch or is this
> sufficient?

You appear to have submitted it as a separate patch just now ;p

Will queue and push to libata-dev.git#upstream (and thus linux-next)

      Jeff

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-09-14 22:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20120914173813.fa65528e5236bd0a20c29b92@canb.auug.org.au>
2012-09-14 17:04 ` linux-next: Tree for Sept 14 (sata_highhbank) Randy Dunlap
2012-09-14 22:02   ` Mark Langsdorf
2012-09-14 22:17     ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).