From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] sata_highbank: use ATA_BUSY Date: Wed, 21 Nov 2012 22:35:17 +0300 Message-ID: <50AD2CF5.6080907@mvista.com> References: <201211012059.29109.sshtylyov@ru.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-la0-f46.google.com ([209.85.215.46]:50261 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755524Ab2KUSek (ORCPT ); Wed, 21 Nov 2012 13:34:40 -0500 Received: by mail-la0-f46.google.com with SMTP id p5so3071792lag.19 for ; Wed, 21 Nov 2012 10:34:39 -0800 (PST) In-Reply-To: <201211012059.29109.sshtylyov@ru.mvista.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Sergei Shtylyov Cc: linux-ide@vger.kernel.org, jgarzik@pobox.com Hello. On 11/01/2012 08:59 PM, Sergei Shtylyov wrote: > ahci_highbank_hardreset() uses bare number for the BSY bit of the ATA status > register, despite it is #define'd in > Signed-off-by: Sergei Shtylyov > --- > The patch is atop of the 'upstream' branch of libata-dev.git... > drivers/ata/sata_highbank.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Index: libata-dev/drivers/ata/sata_highbank.c > =================================================================== > --- libata-dev.orig/drivers/ata/sata_highbank.c > +++ libata-dev/drivers/ata/sata_highbank.c > @@ -213,7 +213,7 @@ static int ahci_highbank_hardreset(struc > > /* clear D2H reception area to properly wait for D2H FIS */ > ata_tf_init(link->device, &tf); > - tf.command = 0x80; > + tf.command = ATA_BUSY; > ata_tf_to_fis(&tf, 0, 0, d2h_fis); > > do { Jeff, are you going to queue this one and earlier patches from me? MBR, Sergei