* [PATCH] sata_highbank: use ATA_BUSY
@ 2012-11-01 17:59 Sergei Shtylyov
2012-11-21 19:35 ` Sergei Shtylyov
2012-11-28 17:42 ` Jeff Garzik
0 siblings, 2 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2012-11-01 17:59 UTC (permalink / raw)
To: linux-ide, jgarzik
ahci_highbank_hardreset() uses bare number for the BSY bit of the ATA status
register, despite it is #define'd in <linux/ata.h>
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
The patch is atop of the 'upstream' branch of libata-dev.git...
drivers/ata/sata_highbank.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: libata-dev/drivers/ata/sata_highbank.c
===================================================================
--- libata-dev.orig/drivers/ata/sata_highbank.c
+++ libata-dev/drivers/ata/sata_highbank.c
@@ -213,7 +213,7 @@ static int ahci_highbank_hardreset(struc
/* clear D2H reception area to properly wait for D2H FIS */
ata_tf_init(link->device, &tf);
- tf.command = 0x80;
+ tf.command = ATA_BUSY;
ata_tf_to_fis(&tf, 0, 0, d2h_fis);
do {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] sata_highbank: use ATA_BUSY
2012-11-01 17:59 [PATCH] sata_highbank: use ATA_BUSY Sergei Shtylyov
@ 2012-11-21 19:35 ` Sergei Shtylyov
2012-11-21 19:43 ` Jeff Garzik
2012-11-28 17:42 ` Jeff Garzik
1 sibling, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2012-11-21 19:35 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide, jgarzik
Hello.
On 11/01/2012 08:59 PM, Sergei Shtylyov wrote:
> ahci_highbank_hardreset() uses bare number for the BSY bit of the ATA status
> register, despite it is #define'd in <linux/ata.h>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> ---
> The patch is atop of the 'upstream' branch of libata-dev.git...
> drivers/ata/sata_highbank.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> Index: libata-dev/drivers/ata/sata_highbank.c
> ===================================================================
> --- libata-dev.orig/drivers/ata/sata_highbank.c
> +++ libata-dev/drivers/ata/sata_highbank.c
> @@ -213,7 +213,7 @@ static int ahci_highbank_hardreset(struc
>
> /* clear D2H reception area to properly wait for D2H FIS */
> ata_tf_init(link->device, &tf);
> - tf.command = 0x80;
> + tf.command = ATA_BUSY;
> ata_tf_to_fis(&tf, 0, 0, d2h_fis);
>
> do {
Jeff, are you going to queue this one and earlier patches from me?
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] sata_highbank: use ATA_BUSY
2012-11-21 19:35 ` Sergei Shtylyov
@ 2012-11-21 19:43 ` Jeff Garzik
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2012-11-21 19:43 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Sergei Shtylyov, linux-ide
On 11/21/2012 02:35 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 11/01/2012 08:59 PM, Sergei Shtylyov wrote:
>
>> ahci_highbank_hardreset() uses bare number for the BSY bit of the ATA status
>> register, despite it is #define'd in <linux/ata.h>
>
>> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
>> ---
>> The patch is atop of the 'upstream' branch of libata-dev.git...
>
>> drivers/ata/sata_highbank.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>> Index: libata-dev/drivers/ata/sata_highbank.c
>> ===================================================================
>> --- libata-dev.orig/drivers/ata/sata_highbank.c
>> +++ libata-dev/drivers/ata/sata_highbank.c
>> @@ -213,7 +213,7 @@ static int ahci_highbank_hardreset(struc
>>
>> /* clear D2H reception area to properly wait for D2H FIS */
>> ata_tf_init(link->device, &tf);
>> - tf.command = 0x80;
>> + tf.command = ATA_BUSY;
>> ata_tf_to_fis(&tf, 0, 0, d2h_fis);
>>
>> do {
>
> Jeff, are you going to queue this one and earlier patches from me?
Yep, should be queued in next 24-48 hours with a bunch of other stuff.
Wanted to get #upstream-fixes upstream and settled first.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sata_highbank: use ATA_BUSY
2012-11-01 17:59 [PATCH] sata_highbank: use ATA_BUSY Sergei Shtylyov
2012-11-21 19:35 ` Sergei Shtylyov
@ 2012-11-28 17:42 ` Jeff Garzik
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2012-11-28 17:42 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide
On 11/01/2012 01:59 PM, Sergei Shtylyov wrote:
> ahci_highbank_hardreset() uses bare number for the BSY bit of the ATA status
> register, despite it is #define'd in <linux/ata.h>
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> ---
> The patch is atop of the 'upstream' branch of libata-dev.git...
>
> drivers/ata/sata_highbank.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-28 17:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-01 17:59 [PATCH] sata_highbank: use ATA_BUSY Sergei Shtylyov
2012-11-21 19:35 ` Sergei Shtylyov
2012-11-21 19:43 ` Jeff Garzik
2012-11-28 17:42 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).