From: Jeff Garzik <jgarzik@pobox.com>
To: Aaron Lu <aaron.lu@intel.com>
Cc: Borislav Petkov <bp@alien8.de>,
Dutra Julio <dutra.julio@gmail.com>,
Phillip Wood <phillip.wood@dunelm.org.uk>,
Tejun Heo <tj@kernel.org>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Szymon Janc <szymon@janc.net.pl>,
Bernd Buschinski <b.buschinski@googlemail.com>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: set dma_mode to 0xff in reset
Date: Mon, 03 Dec 2012 05:07:37 -0500 [thread overview]
Message-ID: <50BC79E9.1030108@pobox.com> (raw)
In-Reply-To: <50BC1DE6.7080008@intel.com>
On 12/02/2012 10:35 PM, Aaron Lu wrote:
>
> ata_device->dma_mode's initial value is zero, which is not a valid dma
> mode, but ata_dma_enabled will return true for this value. This patch
> sets dma_mode to 0xff in reset function, so that ata_dma_enabled will
> not return true for this case, or it will cause problem for pata_acpi.
>
> The corrsponding bugzilla page is at:
> https://bugzilla.kernel.org/show_bug.cgi?id=49151
>
> Reported-by: Phillip Wood <phillip.wood@dunelm.org.uk>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
> Tested-by: Szymon Janc <szymon@janc.net.pl>
> Tested-by: Dutra Julio <dutra.julio@gmail.com>
> Cc: <stable@kernel.org>
> ---
> drivers/ata/libata-core.c | 1 +
> drivers/ata/libata-eh.c | 1 +
> 2 files changed, 2 insertions(+)
applied
prev parent reply other threads:[~2012-12-03 10:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 1:04 [PATCH] libata: fix ata_dma_enabled Aaron Lu
2012-12-03 1:22 ` Alan Cox
2012-12-03 1:35 ` Aaron Lu
2012-12-03 1:46 ` Alan Cox
2012-12-03 3:35 ` [PATCH] libata: set dma_mode to 0xff in reset Aaron Lu
2012-12-03 9:43 ` Alan Cox
2012-12-03 10:07 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BC79E9.1030108@pobox.com \
--to=jgarzik@pobox.com \
--cc=aaron.lu@intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=b.buschinski@googlemail.com \
--cc=bp@alien8.de \
--cc=dutra.julio@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=phillip.wood@dunelm.org.uk \
--cc=szymon@janc.net.pl \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).