From: Jeff Garzik <jgarzik@pobox.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: David Daney <ddaney.cavm@gmail.com>,
linux-ide@vger.kernel.org, Tejun Heo <tj@kernel.org>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH v2 2/4] pata_octeon_cf: perform host detach, removal on exit
Date: Fri, 14 Dec 2012 09:37:20 -0500 [thread overview]
Message-ID: <50CB39A0.2050102@pobox.com> (raw)
In-Reply-To: <CAN8TOE_Zmd8ek-OXqHKiuQ57aUF7BdLFX2KOD-20tt8EBDhg+Q@mail.gmail.com>
On 12/04/2012 01:10 AM, Brian Norris wrote:
>> >I can seem to find it. Without knowing what that does, I would be inclined
>> >to NACK the whole thing.
> A NACK is probably the right thing. I was mostly converting a few
> other drivers which used some simple, common patterns to use my new
> common code, but this driver was missing it altogether. It looks like
> there may be bigger issues, though, as you point out.
>
>> >How did you test the patch?
> I didn't; I don't have a cavium-octeon system.
>
>> >This patch is likely to be incomplete as the driver is also missing the
>> >module_exit() things.
>> >
>> >It might be simpler to just make the driver "bool" instead of "tristate" in
>> >the Kconfig.
> As noted earlier, I don't have much interest in this driver. I agree
> that there are some other issues with the driver; I think it leaks
> memory if it is ever allowed to unload, for one. Feel free to submit
> an alternative patch to prevent this driver from being built as a
> module.
reverted
next prev parent reply other threads:[~2012-12-14 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 18:34 [PATCH v3 1/4] sata_highbank: utilize common ata_platform_remove_one() Brian Norris
2012-12-03 18:34 ` [PATCH v2 2/4] pata_octeon_cf: perform host detach, removal on exit Brian Norris
2012-12-04 0:26 ` David Daney
2012-12-04 6:10 ` Brian Norris
2012-12-14 14:37 ` Jeff Garzik [this message]
2012-12-03 18:34 ` [PATCH v2 3/4] libata: use pci_get_drvdata() helper Brian Norris
2012-12-03 18:34 ` [PATCH v2 4/4] pata_of_platform: fix compile error Brian Norris
2012-12-03 18:55 ` [PATCH v3 1/4] sata_highbank: utilize common ata_platform_remove_one() Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CB39A0.2050102@pobox.com \
--to=jgarzik@pobox.com \
--cc=computersforpeace@gmail.com \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).