From: Jeff Garzik <jgarzik@pobox.com>
To: "Huang, Shane" <Shane.Huang@amd.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"bp@alien8.de" <bp@alien8.de>
Subject: Re: [PATCH] libata: check SATA_SETTINGS log with HW Feature Ctrl
Date: Fri, 14 Dec 2012 09:37:33 -0500 [thread overview]
Message-ID: <50CB39AD.7070104@pobox.com> (raw)
In-Reply-To: <43EB3AB3EEFE8D43B525F4D2EAF507E107F2FA7F@SCYBEXDAG04.amd.com>
On 12/11/2012 04:25 AM, Huang, Shane wrote:
> Jeff,
>
>>> This patch is not tested on SATA HDD with DevSlp supported.
>>>
>>> Reported-by: Borislav Petkov <bp@amd64.org>
>>> Signed-off-by: Shane Huang <shane.huang@amd.com>
>>> ---
>>> drivers/ata/libata-core.c | 3 +--
>>> include/linux/ata.h | 1 +
>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> applied
>
> Please suspend this patch because I just received two new
> DevSlp drives but found word 78 bit 5 is _not_ set.
>
> I'm checking with the drive vendor whether he gave me
> the wrong information. If bit 5 is not the necessary and
> sufficient condition, I will implement another patch to
> replace ata_device->sata_settings into ->devslp_timing.
reverted
prev parent reply other threads:[~2012-12-14 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 20:44 [PATCH] libata: check SATA_SETTINGS log with HW Feature Ctrl Shane Huang
2012-12-03 9:58 ` Jeff Garzik
2012-12-11 9:25 ` Huang, Shane
2012-12-14 14:37 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CB39AD.7070104@pobox.com \
--to=jgarzik@pobox.com \
--cc=Shane.Huang@amd.com \
--cc=bp@alien8.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).