* Fix ahci don't retry commands after a success error handler.
@ 2013-01-06 5:14 y b
2013-01-14 18:10 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: y b @ 2013-01-06 5:14 UTC (permalink / raw)
To: jgarzik, kernel; +Cc: linux-ide
>From 78c0fb104c9957db682518b97ce6a01ce1bc07b6 Mon Sep 17 00:00:00 2001
From: Bian Yu <bianyu@kedacom.com>
Date: Wed, 12 Dec 2012 22:26:58 -0500
Subject: [PATCH] It should be a mistake introduced by commit 8d899e70c1b3afff.
because only qc->flags can't be set AC_ERR_*
Signed-off-by: Bian Yu <bianyu@kedacom.com>
---
drivers/ata/libata-eh.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index bf039b0..bcf4437 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -2094,7 +2094,7 @@ static unsigned int ata_eh_speed_down(struct
ata_device *dev,
*/
static inline int ata_eh_worth_retry(struct ata_queued_cmd *qc)
{
- if (qc->flags & AC_ERR_MEDIA)
+ if (qc->err_mask & AC_ERR_MEDIA)
return 0; /* don't retry media errors */
if (qc->flags & ATA_QCFLAG_IO)
return 1; /* otherwise retry anything from fs stack */
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: Fix ahci don't retry commands after a success error handler.
2013-01-06 5:14 Fix ahci don't retry commands after a success error handler y b
@ 2013-01-14 18:10 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2013-01-14 18:10 UTC (permalink / raw)
To: y b; +Cc: kernel, linux-ide
On 01/06/2013 12:14 AM, y b wrote:
>>From 78c0fb104c9957db682518b97ce6a01ce1bc07b6 Mon Sep 17 00:00:00 2001
> From: Bian Yu <bianyu@kedacom.com>
> Date: Wed, 12 Dec 2012 22:26:58 -0500
> Subject: [PATCH] It should be a mistake introduced by commit 8d899e70c1b3afff.
> because only qc->flags can't be set AC_ERR_*
>
> Signed-off-by: Bian Yu <bianyu@kedacom.com>
> ---
> drivers/ata/libata-eh.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index bf039b0..bcf4437 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -2094,7 +2094,7 @@ static unsigned int ata_eh_speed_down(struct
> ata_device *dev,
> */
> static inline int ata_eh_worth_retry(struct ata_queued_cmd *qc)
> {
> - if (qc->flags & AC_ERR_MEDIA)
> + if (qc->err_mask & AC_ERR_MEDIA)
> return 0; /* don't retry media errors */
> if (qc->flags & ATA_QCFLAG_IO)
applied, good catch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-14 18:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-06 5:14 Fix ahci don't retry commands after a success error handler y b
2013-01-14 18:10 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).