* [PATCH] [libata] Avoid specialized TLA's in ZPODD's Kconfig
[not found] ` <512CF809.8010102@pobox.com>
@ 2013-03-01 1:32 ` Aaron Lu
2013-03-01 13:10 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Aaron Lu @ 2013-03-01 1:32 UTC (permalink / raw)
To: Jeff Garzik
Cc: Tejun Heo, Linus Torvalds, linux-ide@vger.kernel.org, Jeff Garzik,
Rafael J. Wysocki, LKML, Linux PM list
ODD is not a common TLA for non-ATA people so they will get confused
by its meaning when they are configuring the kernel. This patch fixed
this problem by using ODD only after stating what it is.
Signed-off-by: Aaron Lu <aaron.lu@intel.com>
---
drivers/ata/Kconfig | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 3e751b7..d7d210e 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -59,15 +59,16 @@ config ATA_ACPI
option libata.noacpi=1
config SATA_ZPODD
- bool "SATA Zero Power ODD Support"
+ bool "SATA Zero Power Optical Disc Drive(ZPODD) support"
depends on ATA_ACPI
default n
help
- This option adds support for SATA ZPODD. It requires both
- ODD and the platform support, and if enabled, will automatically
- power on/off the ODD when certain condition is satisfied. This
- does not impact user's experience of the ODD, only power is saved
- when ODD is not in use(i.e. no disc inside).
+ This option adds support for SATA Zero Power Optical Disc
+ Drive(ZPODD). It requires both the ODD and the platform
+ support, and if enabled, will automatically power on/off the
+ ODD when certain condition is satisfied. This does not impact
+ end user's experience of the ODD, only power is saved when
+ the ODD is not in use(i.e. no disc inside).
If unsure, say N.
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [libata] Avoid specialized TLA's in ZPODD's Kconfig
2013-03-01 1:32 ` [PATCH] [libata] Avoid specialized TLA's in ZPODD's Kconfig Aaron Lu
@ 2013-03-01 13:10 ` Sergei Shtylyov
2013-03-02 5:00 ` [PATCH v2] " Aaron Lu
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2013-03-01 13:10 UTC (permalink / raw)
To: Aaron Lu
Cc: Jeff Garzik, Tejun Heo, Linus Torvalds, linux-ide@vger.kernel.org,
Jeff Garzik, Rafael J. Wysocki, LKML, Linux PM list
Hello.
On 01-03-2013 5:32, Aaron Lu wrote:
> ODD is not a common TLA for non-ATA people so they will get confused
> by its meaning when they are configuring the kernel. This patch fixed
> this problem by using ODD only after stating what it is.
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
> ---
> drivers/ata/Kconfig | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 3e751b7..d7d210e 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -59,15 +59,16 @@ config ATA_ACPI
> option libata.noacpi=1
>
> config SATA_ZPODD
> - bool "SATA Zero Power ODD Support"
> + bool "SATA Zero Power Optical Disc Drive(ZPODD) support"
Need a space before open paren.
> depends on ATA_ACPI
> default n
> help
> - This option adds support for SATA ZPODD. It requires both
> - ODD and the platform support, and if enabled, will automatically
> - power on/off the ODD when certain condition is satisfied. This
> - does not impact user's experience of the ODD, only power is saved
> - when ODD is not in use(i.e. no disc inside).
> + This option adds support for SATA Zero Power Optical Disc
> + Drive(ZPODD). It requires both the ODD and the platform
Same here.
> + support, and if enabled, will automatically power on/off the
> + ODD when certain condition is satisfied. This does not impact
> + end user's experience of the ODD, only power is saved when
> + the ODD is not in use(i.e. no disc inside).
And here.
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] [libata] Avoid specialized TLA's in ZPODD's Kconfig
2013-03-01 13:10 ` Sergei Shtylyov
@ 2013-03-02 5:00 ` Aaron Lu
2013-03-04 22:14 ` Jeff Garzik
0 siblings, 1 reply; 4+ messages in thread
From: Aaron Lu @ 2013-03-02 5:00 UTC (permalink / raw)
To: Jeff Garzik
Cc: Sergei Shtylyov, Tejun Heo, Linus Torvalds,
linux-ide@vger.kernel.org, Jeff Garzik, Rafael J. Wysocki, LKML,
Linux PM list
ODD is not a common TLA for non-ATA people so they will get confused
by its meaning when they are configuring the kernel. This patch fixed
this problem by using ODD only after stating what it is.
Signed-off-by: Aaron Lu <aaron.lu@intel.com>
---
v2:
Add a space before open paren as suggested by Sergei Shtylyov.
drivers/ata/Kconfig | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 3e751b7..a5a3ebc 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -59,15 +59,16 @@ config ATA_ACPI
option libata.noacpi=1
config SATA_ZPODD
- bool "SATA Zero Power ODD Support"
+ bool "SATA Zero Power Optical Disc Drive (ZPODD) support"
depends on ATA_ACPI
default n
help
- This option adds support for SATA ZPODD. It requires both
- ODD and the platform support, and if enabled, will automatically
- power on/off the ODD when certain condition is satisfied. This
- does not impact user's experience of the ODD, only power is saved
- when ODD is not in use(i.e. no disc inside).
+ This option adds support for SATA Zero Power Optical Disc
+ Drive (ZPODD). It requires both the ODD and the platform
+ support, and if enabled, will automatically power on/off the
+ ODD when certain condition is satisfied. This does not impact
+ end user's experience of the ODD, only power is saved when
+ the ODD is not in use (i.e. no disc inside).
If unsure, say N.
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] [libata] Avoid specialized TLA's in ZPODD's Kconfig
2013-03-02 5:00 ` [PATCH v2] " Aaron Lu
@ 2013-03-04 22:14 ` Jeff Garzik
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2013-03-04 22:14 UTC (permalink / raw)
To: Aaron Lu
Cc: Sergei Shtylyov, Tejun Heo, Linus Torvalds,
linux-ide@vger.kernel.org, Jeff Garzik, Rafael J. Wysocki, LKML,
Linux PM list
On 03/02/2013 12:00 AM, Aaron Lu wrote:
> ODD is not a common TLA for non-ATA people so they will get confused
> by its meaning when they are configuring the kernel. This patch fixed
> this problem by using ODD only after stating what it is.
>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
> ---
> v2:
> Add a space before open paren as suggested by Sergei Shtylyov.
>
> drivers/ata/Kconfig | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
applied
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-04 22:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1663657.ypAtqGpGAq@vostro.rjw.lan>
[not found] ` <1781256.mPQbtiUPYR@vostro.rjw.lan>
[not found] ` <CA+55aFyzjN_wMH+2RCEA+aNLY0Z7fn4YU7VOtTALbgngn1+vCw@mail.gmail.com>
[not found] ` <2223198.XmyRLgb3Gv@vostro.rjw.lan>
[not found] ` <20130226161049.GA9303@kahuna>
[not found] ` <CA+55aFy24fp+9zXiDmAgvsz6YvWQh2L0BAJ2hAhF7cNSdyMd8w@mail.gmail.com>
[not found] ` <CA+55aFyu5woJsH2y3y=w4UFneOG8hKz_cLXgZQbJzn5asn8=hQ@mail.gmail.com>
[not found] ` <20130226163712.GA30433@htj.dyndns.org>
[not found] ` <CA+55aFyFRbMX9G_0Mv0nUZgw9mHAPzE0zCw5mCSbGG_r1diFHg@mail.gmail.com>
[not found] ` <20130226165813.GB30433@htj.dyndns.org>
[not found] ` <512CF809.8010102@pobox.com>
2013-03-01 1:32 ` [PATCH] [libata] Avoid specialized TLA's in ZPODD's Kconfig Aaron Lu
2013-03-01 13:10 ` Sergei Shtylyov
2013-03-02 5:00 ` [PATCH v2] " Aaron Lu
2013-03-04 22:14 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).