[PATCH 1/1] [libata] SCSI: really use SATL version in VPD

[PATCH 1/1] [libata] SCSI: really use SATL version in VPD

[Baruch Even]

Commit message of c78968bb by Jeff Garzik says we need to provide the SATL
driver version and not the disk firmware version but the code overwrites the
driver version with the disk version.

Signed-off-by: Baruch Even <baruch@ev-en.org>
---
 drivers/ata/libata-scsi.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 318b413..e61a054 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -2126,7 +2126,6 @@ static unsigned int ata_scsiop_inq_89(struct ata_scsi_args *args, u8 *rbuf)
 	memcpy(&rbuf[8], "linux   ", 8);
 	memcpy(&rbuf[16], "libata          ", 16);
 	memcpy(&rbuf[32], DRV_VERSION, 4);
-	ata_id_string(args->id, &rbuf[32], ATA_ID_FW_REV, 4);
 
 	/* we don't store the ATA device signature, so we fake it */
 
-- 
1.7.10.4

Re: [PATCH 1/1] [libata] SCSI: really use SATL version in VPD

[Sergei Shtylyov]

Hello.

On 05-04-2013 15:48, Baruch Even wrote:

> Commit message of c78968bb

    Please also specify the summary line of that commit in parens (or however 
you like).

> by Jeff Garzik says we need to provide the SATL
> driver version and not the disk firmware version but the code overwrites the
> driver version with the disk version.

> Signed-off-by: Baruch Even <baruch@ev-en.org>

WBR, Sergei

[PATCH 1/1] [libata] SCSI: really use SATL version in VPD

[Baruch Even]

As per c78968bb by Jeff Garzik ([libata] SCSI: simulator version, not device version, belongs in VPD)
We need to provide the SATL driver version and not the disk firmware version
but the code overwrites the driver version with the disk version.

Signed-off-by: Baruch Even <baruch@ev-en.org>
---
 drivers/ata/libata-scsi.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 318b413..e61a054 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -2126,7 +2126,6 @@ static unsigned int ata_scsiop_inq_89(struct ata_scsi_args *args, u8 *rbuf)
 	memcpy(&rbuf[8], "linux   ", 8);
 	memcpy(&rbuf[16], "libata          ", 16);
 	memcpy(&rbuf[32], DRV_VERSION, 4);
-	ata_id_string(args->id, &rbuf[32], ATA_ID_FW_REV, 4);
 
 	/* we don't store the ATA device signature, so we fake it */
 
-- 
1.7.10.4

Re: [PATCH 1/1] [libata] SCSI: really use SATL version in VPD

[Baruch Even]

OK. Resending.

On Fri, Apr 5, 2013 at 5:44 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
> On 05-04-2013 15:48, Baruch Even wrote:
>
>> Commit message of c78968bb
>
>
>    Please also specify the summary line of that commit in parens (or however
> you like).
>
>
>> by Jeff Garzik says we need to provide the SATL
>> driver version and not the disk firmware version but the code overwrites
>> the
>> driver version with the disk version.
>
>
>> Signed-off-by: Baruch Even <baruch@ev-en.org>
>
>
> WBR, Sergei
>

Re: [PATCH 1/1] [libata] SCSI: really use SATL version in VPD

[Sergei Shtylyov]

Hello.

On 05-04-2013 18:50, Baruch Even wrote:

    When you post a new revision of the patch, this should be marked in the 
subject, like this: {PATCH v2].

> As per c78968bb by Jeff Garzik ([libata] SCSI: simulator version, not device version, belongs in VPD)

    Please wrap your lines at 80 characters max.

> We need to provide the SATL driver version and not the disk firmware version
> but the code overwrites the driver version with the disk version.

> Signed-off-by: Baruch Even <baruch@ev-en.org>

WBR, Sergei