* [PATCH 1/1] libata: sata_rcar: Convert to devm_ioremap_resource()
@ 2013-04-04 9:26 Sachin Kamat
2013-04-04 14:43 ` Sergei Shtylyov
2013-04-11 23:35 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-04-04 9:26 UTC (permalink / raw)
To: linux-ide; +Cc: jgarzik, vladimir.barinov, sachin.kamat
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/ata/sata_rcar.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
index caf33f6..4799868 100644
--- a/drivers/ata/sata_rcar.c
+++ b/drivers/ata/sata_rcar.c
@@ -17,6 +17,7 @@
#include <linux/libata.h>
#include <linux/platform_device.h>
#include <linux/clk.h>
+#include <linux/err.h>
#define DRV_NAME "sata_rcar"
@@ -799,9 +800,9 @@ static int sata_rcar_probe(struct platform_device *pdev)
host->private_data = priv;
- priv->base = devm_request_and_ioremap(&pdev->dev, mem);
- if (!priv->base) {
- ret = -EADDRNOTAVAIL;
+ priv->base = devm_ioremap_resource(&pdev->dev, mem);
+ if (IS_ERR(priv->base)) {
+ ret = PTR_ERR(priv->base);
goto cleanup;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] libata: sata_rcar: Convert to devm_ioremap_resource()
2013-04-04 9:26 [PATCH 1/1] libata: sata_rcar: Convert to devm_ioremap_resource() Sachin Kamat
@ 2013-04-04 14:43 ` Sergei Shtylyov
2013-04-11 23:35 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2013-04-04 14:43 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-ide, jgarzik, vladimir.barinov
Hello.
On 04-04-2013 13:26, Sachin Kamat wrote:
> Use the newly introduced devm_ioremap_resource() instead of
> devm_request_and_ioremap() which provides more consistent error handling.
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] libata: sata_rcar: Convert to devm_ioremap_resource()
2013-04-04 9:26 [PATCH 1/1] libata: sata_rcar: Convert to devm_ioremap_resource() Sachin Kamat
2013-04-04 14:43 ` Sergei Shtylyov
@ 2013-04-11 23:35 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2013-04-11 23:35 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-ide, vladimir.barinov
On 04/04/2013 05:26 AM, Sachin Kamat wrote:
> Use the newly introduced devm_ioremap_resource() instead of
> devm_request_and_ioremap() which provides more consistent error handling.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/ata/sata_rcar.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-11 23:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-04 9:26 [PATCH 1/1] libata: sata_rcar: Convert to devm_ioremap_resource() Sachin Kamat
2013-04-04 14:43 ` Sergei Shtylyov
2013-04-11 23:35 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).