* [PATCH v3 1/1] [libata] SCSI: really use SATL version in VPD [not found] <satl-driver-version-v3> @ 2013-04-05 16:11 ` Baruch Even 2013-04-11 23:45 ` Jeff Garzik 0 siblings, 1 reply; 2+ messages in thread From: Baruch Even @ 2013-04-05 16:11 UTC (permalink / raw) To: Jeff Garzik, linux-ide; +Cc: Baruch Even As per c78968bb by Jeff Garzik ([libata] SCSI: simulator version, not device version, belongs in VPD) We need to provide the SATL driver version and not the disk firmware version but the code overwrites the driver version with the disk version. Signed-off-by: Baruch Even <baruch@ev-en.org> --- drivers/ata/libata-scsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 318b413..e61a054 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -2126,7 +2126,6 @@ static unsigned int ata_scsiop_inq_89(struct ata_scsi_args *args, u8 *rbuf) memcpy(&rbuf[8], "linux ", 8); memcpy(&rbuf[16], "libata ", 16); memcpy(&rbuf[32], DRV_VERSION, 4); - ata_id_string(args->id, &rbuf[32], ATA_ID_FW_REV, 4); /* we don't store the ATA device signature, so we fake it */ -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 1/1] [libata] SCSI: really use SATL version in VPD 2013-04-05 16:11 ` [PATCH v3 1/1] [libata] SCSI: really use SATL version in VPD Baruch Even @ 2013-04-11 23:45 ` Jeff Garzik 0 siblings, 0 replies; 2+ messages in thread From: Jeff Garzik @ 2013-04-11 23:45 UTC (permalink / raw) To: Baruch Even; +Cc: linux-ide On 04/05/2013 12:11 PM, Baruch Even wrote: > As per c78968bb by Jeff Garzik ([libata] SCSI: simulator version, not device > version, belongs in VPD) We need to provide the SATL driver version and not the > disk firmware version but the code overwrites the driver version with the disk > version. > > Signed-off-by: Baruch Even <baruch@ev-en.org> > --- > drivers/ata/libata-scsi.c | 1 - > 1 file changed, 1 deletion(-) applied ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-11 23:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <satl-driver-version-v3>
2013-04-05 16:11 ` [PATCH v3 1/1] [libata] SCSI: really use SATL version in VPD Baruch Even
2013-04-11 23:45 ` Jeff Garzik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).