From: David Daney <ddaney@caviumnetworks.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: David Daney <ddaney.cavm@gmail.com>,
linux-mips@linux-mips.org, ralf@linux-mips.org,
David Daney <david.daney@cavium.com>,
linux-ide@vger.kernel.org, linux-edac@vger.kernel.org,
linux-i2c@vger.kernel.org, netdev@vger.kernel.org,
spi-devel-general@lists.sourceforge.net,
devel@driverdev.osuosl.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD to CAVIUM_OCTEON_SOC
Date: Tue, 21 May 2013 15:07:23 -0700 [thread overview]
Message-ID: <519BF01B.1010600@caviumnetworks.com> (raw)
In-Reply-To: <20130521220457.GF31836@blackmetal.musicnaut.iki.fi>
On 05/21/2013 03:04 PM, Aaro Koskinen wrote:
> Hi,
>
> What about OCTEON_WDT, should it be changed too:
>
> tristate "Cavium OCTEON SOC family Watchdog Timer"
> depends on CPU_CAVIUM_OCTEON
>
> On Mon, May 20, 2013 at 03:19:38PM -0700, David Daney wrote:
>> config OCTEON_MGMT_ETHERNET
>> tristate "Octeon Management port ethernet driver (CN5XXX, CN6XXX)"
>> - depends on CPU_CAVIUM_OCTEON
>> + depends on CAVIUM_OCTEON_SOC
>
>> config MDIO_OCTEON
>> tristate "Support for MDIO buses on Octeon SOCs"
>> - depends on CPU_CAVIUM_OCTEON
>> + depends on CAVIUM_OCTEON_SOC
>
>> config USB_OCTEON_OHCI
>> bool "Octeon on-chip OHCI support"
>> - depends on CPU_CAVIUM_OCTEON
>> + depends on CAVIUM_OCTEON_SOC
>
> Just a minor comment, here the extra whitespace after "depends on"
> could be eliminated.
>
Good point. I will regenerate the patch to correct this.
Thanks,
David Daney
next prev parent reply other threads:[~2013-05-21 22:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 22:19 [PATCH] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD to CAVIUM_OCTEON_SOC David Daney
2013-05-20 23:10 ` Greg KH
[not found] ` <1369088378-13957-1-git-send-email-ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-05-21 9:26 ` Wolfram Sang
2013-05-21 10:25 ` Mauro Carvalho Chehab
2013-05-21 22:04 ` Aaro Koskinen
2013-05-21 22:07 ` David Daney [this message]
[not found] ` <519BF01B.1010600-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2013-05-22 12:22 ` Ralf Baechle
2013-05-22 16:13 ` David Daney
2013-05-22 17:14 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519BF01B.1010600@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=aaro.koskinen@iki.fi \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox