Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org, vladimir.barinov@cogentembedded.com
Subject: Re: [PATCH] sata_rcar: clear STOP bit in bmdma_start() method
Date: Wed, 22 May 2013 17:12:48 +0400	[thread overview]
Message-ID: <519CC450.6030203@cogentembedded.com> (raw)
In-Reply-To: <20130521234128.GD6985@mtj.dyndns.org>

Hello.

On 22-05-2013 3:41, Tejun Heo wrote:

>> Iff bmdma_setup() has to stop a DMA transfer before starting a new one, then the
>> STOP bit in the ATAPI_CONTROL1 register will remain set (it's only cleared when
>> setting the START bit to 1) and then bmdma_start() method will set both START
>> and STOP bits simultaneously which should abort the transfer being just started.
>> Avoid that by explicitly clearing the STOP bit in bmdma_start() method (in this
>> case it will be ignored on write).

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

> Applied to libata/for-3.10-fixes w/ stable cc'd.

    Thanks, I forgot about -stable. Anyway, it doesn't seem that serious 
as bmdma_setup() usually shouldn't abort DMA.

> Thanks.

WBR, Sergei


  reply	other threads:[~2013-05-22 13:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21 19:07 [PATCH] sata_rcar: clear STOP bit in bmdma_start() method Sergei Shtylyov
2013-05-21 23:41 ` Tejun Heo
2013-05-22 13:12   ` Sergei Shtylyov [this message]
2013-05-23 12:14     ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519CC450.6030203@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=vladimir.barinov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox