From: Mark Langsdorf <mark.langsdorf@calxeda.com>
To: Timur Tabi <timur@tabi.org>
Cc: lkml <linux-kernel@vger.kernel.org>, Tejun Heo <tj@kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] ata: increase retry count but shorten duration for Calxeda controller
Date: Wed, 29 May 2013 15:35:28 -0500 [thread overview]
Message-ID: <51A66690.6060109@calxeda.com> (raw)
In-Reply-To: <CAOZdJXUHb1Kbu=LoqUgKA3_EMjPU3Q1KrZ-pENb-0Siym8_Pvw@mail.gmail.com>
On 05/29/2013 03:12 PM, Timur Tabi wrote:
> On Wed, May 29, 2013 at 10:51 AM, Mark Langsdorf
> <mark.langsdorf@calxeda.com> wrote:
>>
>> {
>> - const unsigned long *timing = sata_ehc_deb_timing(&link->eh_context);
>> + unsigned long timing[] = { 5, 100, 500};
>
>
> You didn't address my comments the last time you posted this. I'll
> post them again:
>
>
> Why are you dropping the 'const'?
>
> Assuming it works, this should be more efficient:
>
> static const unsigned long timing[] = {5, 100, 500};
I thought there was a compile issue, but I just rechecked and there
wasn't. I'll fix for the next submission.
Thanks for the review.
--Mark Langsdorf
next prev parent reply other threads:[~2013-05-29 20:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 15:51 [PATCH] ata: increase retry count but shorten duration for Calxeda controller Mark Langsdorf
2013-05-29 20:12 ` Timur Tabi
2013-05-29 20:35 ` Mark Langsdorf [this message]
2013-05-30 6:58 ` Tejun Heo
2013-05-31 15:27 ` [PATCH v3] " Mark Langsdorf
2013-06-02 8:00 ` Tejun Heo
2013-06-03 12:27 ` Mark Langsdorf
2013-06-03 13:22 ` [PATCH v4] " Mark Langsdorf
2013-06-03 20:39 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2013-05-01 21:34 [PATCH] " Mark Langsdorf
2013-05-06 15:45 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A66690.6060109@calxeda.com \
--to=mark.langsdorf@calxeda.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=timur@tabi.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).