From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Lu Subject: Re: [PATCH] libata: remove dead code from libata-acpi.c Date: Tue, 18 Jun 2013 17:16:33 +0800 Message-ID: <51C02571.3090100@intel.com> References: <1371265368-7334-1-git-send-email-liuj97@gmail.com> <51BE6B5C.70803@intel.com> <20130617180151.GG32663@mtj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com ([134.134.136.20]:27964 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755332Ab3FRJQI (ORCPT ); Tue, 18 Jun 2013 05:16:08 -0400 In-Reply-To: <20130617180151.GG32663@mtj.dyndns.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Matthew Garrett , Liu Jiang , Liu Jiang , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Liu Jiang On 06/18/2013 02:01 AM, Tejun Heo wrote: > On Mon, Jun 17, 2013 at 09:50:20AM +0800, Aaron Lu wrote: >> On 06/15/2013 11:02 AM, Liu Jiang wrote: >>> From: Liu Jiang >>> >>> Commit 30dcf76acc69 "libata: migrate ACPI code over to new bindings" >>> removed ACPI dock notification related code, but there's some dead >>> code left, so clean up it. >> >> I never noticed this, but it looks to be the case... >> >> I'm not sure the dock notification code is removed intentionally or >> mistakenly though, if it is a mistake, then instead of removing the left >> code here, we probably should add the dock notification code back. >> >> But I have no test system or any knowledge about how ata dock works, so >> I may be wrong :-) > > Looks like a regression to me. We're probably locking up on some > older laptops which connects optical drives with hotpluggable PATA. > Matthew, can you please fix it? A user just reported a bug for this: https://bugzilla.kernel.org/show_bug.cgi?id=59871 And bisected to commit 30dcf76acc69. I proposed a fix patch there, let's see what the user's test result. Thanks, Aaron