Re: [PATCH] libata: remove dead code from libata-acpi.c

[Aaron Lu <aaron.lu@intel.com>]

On 06/21/2013 07:35 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 21-06-2013 4:55, Aaron Lu wrote:
> 
>>>> +void ata_acpi_hotplug_init(struct ata_host *host)
>>>> +{
>>>> +	int i;
>>>> +
>>>> +	for (i = 0; i < host->n_ports; i++) {
>>>> +		struct ata_port *ap = host->ports[i];
>>>> +		acpi_handle handle;
>>>> +		struct ata_device *dev;
>>>> +
>>>> +		if (!ap)
>>>> +			continue;
>>>> +
>>>> +		handle = ata_ap_acpi_handle(ap);
>>>> +		if (handle) {
>>>> +			/* we might be on a docking station */
>>>> +			register_hotplug_dock_device(handle,
>>>> +					&ata_acpi_ap_dock_ops, ap);
> 
>>>      Please indent this line under the next character after ( above.
> 
>> Is there a link about this rule? I might have missed something about
>> coding style.
> 
>     Don't think so. This is a rule in some subsystems like networking, 
> and it's also the way Emacs does such things. So, in principle, you can 
> ignore my comment (although libata seems to also use this style).

FYI, the updated patch has been sent by Rafael for me:
http://marc.info/?l=linux-acpi&m=137207724507019&w=2
with your suggestion taken.

Thanks,
Aaron