Re: [PATCH] libata-zpodd: must use ata_tf_init()

[Aaron Lu <aaron.lu@intel.com>]

On 06/28/2013 08:49 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 27-06-2013 5:15, Aaron Lu wrote:
> 
>>>>> There are  some SATA controllers which have both devices 0 and 1 but this module
> 
>>>> Do you mean a SATA port can connect to two SATA devices without PMP?
> 
>>>      No, I mean 2 SATA ports combined in one ATA channel as 2 devices.
>>> Look for SLAVE_POSS in drivers/ata/[s]ata*.c...
> 
>> Oh yes that happened when the SATA controller is in IDE programming
>> mode, not AHCI.
> 
>     AHCI is not the only mode for the SATA controllers.

Right.

> 
>> ZPODD is only supported for SATA controllers in AHCI programming mode,
> 
>     Hm, really? How about the true SATA controllers that don't use AHCI?

If they don't set ATA_FLAG_ACPI_SATA, no.

> 
>> the ACPI table will not support power off the port if the controller is
>> in IDE mode, so the device 1 case shouldn't happen in practice :-)
> 
>     Anyway, I need uniform setup for ata_exec_internal() call for my to 
> be posted cleanup patches.

No problem.

Thanks,
Aaron