From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Joe Perches <joe@perches.com>,
Lan Tianyu <lantianyu1986@gmail.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Yinghai Lu <yinghai@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Aaron Lu <aaron.lu@intel.com>, Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names
Date: Mon, 29 Jul 2013 16:16:31 +0400 [thread overview]
Message-ID: <51F65D1F.9050402@cogentembedded.com> (raw)
In-Reply-To: <1782275.A7JEhQIj8Q@vostro.rjw.lan>
Hello.
On 29-07-2013 16:17, Rafael J. Wysocki wrote:
[...]
>>>> @@ -166,20 +166,20 @@ int acpi_device_set_power(struct acpi_de
>> []
>>>> if (device->parent && (state < device->parent->power.state)) {
>>>> - printk(KERN_WARNING PREFIX
>>>> - "Cannot set device to a higher-powered"
>>>> - " state than parent\n");
>>>> + dev_warn(&device->dev, "Cannot transition to a higher-powered "
>>>> + "state than parent\n");
>> coalesce format please.
> I can, but then it'll cross the 80 columns boundary.
It's not a problem with checkpatch.pl anymore. Contrariwise, it whines
about the broken up string literals, AFAIR.
> Thanks,
> Rafael
WBR, Sergei
next prev parent reply other threads:[~2013-07-29 12:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-27 13:09 [PATCH 0/3] ACPI / PM: Device PM cleanups Rafael J. Wysocki
2013-07-27 13:10 ` [PATCH 1/3] ACPI / PM: Only set power states of devices that are power manageable Rafael J. Wysocki
2013-07-29 14:09 ` Aaron Lu
2013-07-29 22:21 ` Rafael J. Wysocki
2013-07-29 23:43 ` Aaron Lu
2013-07-30 14:04 ` Rafael J. Wysocki
2013-07-31 6:48 ` Aaron Lu
2013-07-31 10:29 ` Rafael J. Wysocki
2013-07-27 13:11 ` [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names Rafael J. Wysocki
2013-07-29 2:29 ` Aaron Lu
2013-07-29 12:20 ` Rafael J. Wysocki
2013-07-31 6:52 ` Aaron Lu
2013-07-31 10:27 ` Rafael J. Wysocki
2013-08-01 0:49 ` [PATCH updated] ACPI / PM: Add state information in error message for acpi_device_set_power Aaron Lu
2013-07-29 3:06 ` [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names Lan Tianyu
2013-07-29 3:11 ` Joe Perches
2013-07-29 12:17 ` Rafael J. Wysocki
2013-07-29 12:16 ` Sergei Shtylyov [this message]
2013-07-29 13:36 ` Rafael J. Wysocki
2013-07-29 14:15 ` Aaron Lu
2013-07-29 12:11 ` Rafael J. Wysocki
2013-07-27 13:14 ` [PATCH 3/3] ACPI / PM: Use ACPI_STATE_D3_COLD instead of ACPI_STATE_D3 everywhere Rafael J. Wysocki
2013-07-29 14:28 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F65D1F.9050402@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=aaron.lu@intel.com \
--cc=bhelgaas@google.com \
--cc=joe@perches.com \
--cc=lantianyu1986@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tj@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).