From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Marc C <marc.ceeeee@gmail.com>
Cc: tj@kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] libata: Add support for SEND/RECEIVE FPDMA QUEUED
Date: Sat, 03 Aug 2013 18:52:32 +0400 [thread overview]
Message-ID: <51FD1930.3000909@cogentembedded.com> (raw)
In-Reply-To: <1375500896-22955-2-git-send-email-marc.ceeeee@gmail.com>
Hello.
On 03-08-2013 7:34, Marc C wrote:
> From: Marc C <marc.ceeeee@gmail.com>
Real name is required in signoff.
> Add support for the following ATA opcodes, which are present
> in SATA 3.1 and T13 ATA ACS-3:
> SEND FPDMA QUEUED
> RECEIVE FPDMA QUEUED
> Signed-off-by: Marc C <marc.ceeeee@gmail.com>
[...]
> diff --git a/include/linux/ata.h b/include/linux/ata.h
> index ee0bd95..dd26211 100644
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
[...]
> @@ -509,6 +525,8 @@ struct ata_taskfile {
> u8 device;
>
> u8 command; /* IO operation */
> +
> + u32 auxiliary;
The 'struct ata_taskfile' has been moved to libata.h for 3.12, so you are
basing your work off of the wrong branch. And what does this new field have to
do with the classical ATA taskfile registers? Can't we place it into 'struct
ata_queued_cmd'?
WBR, Sergei
next prev parent reply other threads:[~2013-08-03 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-03 3:34 [PATCH 0/2] Introduce new SATA queued commands Marc C
2013-08-03 3:34 ` [PATCH 1/2] libata: Add support for SEND/RECEIVE FPDMA QUEUED Marc C
2013-08-03 14:52 ` Sergei Shtylyov [this message]
2013-08-03 16:30 ` Marc C
2013-08-03 3:34 ` [PATCH 2/2] libata: Add support for queued DSM TRIM Marc C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FD1930.3000909@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-ide@vger.kernel.org \
--cc=marc.ceeeee@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).