From: Marc C <marc.ceeeee@gmail.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: tj@kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] libata: Add support for SEND/RECEIVE FPDMA QUEUED
Date: Sat, 03 Aug 2013 09:30:01 -0700 [thread overview]
Message-ID: <51FD3009.5020909@gmail.com> (raw)
In-Reply-To: <51FD1930.3000909@cogentembedded.com>
Hello,
> Real name is required in signoff.
Got it. I will update it in the resubmission.
>> diff --git a/include/linux/ata.h b/include/linux/ata.h
>> index ee0bd95..dd26211 100644
>> --- a/include/linux/ata.h
>> +++ b/include/linux/ata.h
> [...]
>> @@ -509,6 +525,8 @@ struct ata_taskfile {
>> u8 device;
>>
>> u8 command; /* IO operation */
>> +
>> + u32 auxiliary;
>
> The 'struct ata_taskfile' has been moved to libata.h for 3.12, so
> you are basing your work off of the wrong branch.
My bad! I'll rebase my tree to 3.12.
> And what does this new field have to do with the classical ATA
> taskfile registers? Can't we place it into 'struct ata_queued_cmd'?
Actually, nothing, since it's impossible to transport the new field via
a legacy TF. 'struct ata_queued_cmd' is a more appropriate place to put
it. Thank you for pointing that out.
Regards,
Marc
next prev parent reply other threads:[~2013-08-03 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-03 3:34 [PATCH 0/2] Introduce new SATA queued commands Marc C
2013-08-03 3:34 ` [PATCH 1/2] libata: Add support for SEND/RECEIVE FPDMA QUEUED Marc C
2013-08-03 14:52 ` Sergei Shtylyov
2013-08-03 16:30 ` Marc C [this message]
2013-08-03 3:34 ` [PATCH 2/2] libata: Add support for queued DSM TRIM Marc C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FD3009.5020909@gmail.com \
--to=marc.ceeeee@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).