* Re: [PATCH] ahci: disable FPDMA auto-activate optimization on NVIDIA AHCI
2010-01-27 4:33 [PATCH] ahci: disable FPDMA auto-activate optimization on NVIDIA AHCI Robert Hancock
@ 2010-01-31 17:10 ` Robert Hancock
2010-02-13 22:46 ` Jeff Garzik
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Robert Hancock @ 2010-01-31 17:10 UTC (permalink / raw)
To: Mike Cui; +Cc: Peer Chen, linux-kernel, ide, Jeff Garzik
Hi Mike, have you had a chance to try out this patch yet?
On Tue, Jan 26, 2010 at 10:33 PM, Robert Hancock <hancockrwd@gmail.com> wrote:
> Mike Cui reported that his system with an NVIDIA MCP79 (aka MCP7A) chipset
> stopped working with 2.6.32. The problem appears to be that 2.6.32 now enables
> the FPDMA auto-activate optimization in the ahci driver. The drive works fine
> with this enabled on an Intel AHCI so this appears to be a chipset bug.
> Since MCP79 is a fairly recent NVIDIA chipset and we don't have any info on
> whether any other NVIDIA chipsets have this issue, disable FPDMA AA optimization
> on all NVIDIA AHCI controllers for now.
>
> Should address http://bugzilla.kernel.org/show_bug.cgi?id=14922
>
> Signed-off-by: Robert Hancock <hancockrwd@gmail.com>
>
> ---
>
> Mike, can you test this out and make sure this resolves the problem for you?
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index b8bea10..47e57dc 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -3067,8 +3067,16 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> ahci_save_initial_config(pdev, hpriv);
>
> /* prepare host */
> - if (hpriv->cap & HOST_CAP_NCQ)
> - pi.flags |= ATA_FLAG_NCQ | ATA_FLAG_FPDMA_AA;
> + if (hpriv->cap & HOST_CAP_NCQ) {
> + pi.flags |= ATA_FLAG_NCQ;
> + /* Auto-activate optimization is supposed to be supported on
> + all AHCI controllers indicating NCQ support, but it seems
> + to be broken at least on some NVIDIA MCP79 chipsets.
> + Until we get info on which NVIDIA chipsets don't have this
> + issue, if any, disable AA on all NVIDIA AHCIs. */
> + if (pdev->vendor != PCI_VENDOR_ID_NVIDIA)
> + pi.flags |= ATA_FLAG_FPDMA_AA;
> + }
>
> if (hpriv->cap & HOST_CAP_PMP)
> pi.flags |= ATA_FLAG_PMP;
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ahci: disable FPDMA auto-activate optimization on NVIDIA AHCI
2010-01-27 4:33 [PATCH] ahci: disable FPDMA auto-activate optimization on NVIDIA AHCI Robert Hancock
2010-01-31 17:10 ` Robert Hancock
@ 2010-02-13 22:46 ` Jeff Garzik
2010-02-13 22:53 ` Robert Hancock
2010-02-16 22:46 ` Prajakta Gudadhe
2010-02-25 3:45 ` Jeff Garzik
3 siblings, 1 reply; 9+ messages in thread
From: Jeff Garzik @ 2010-02-13 22:46 UTC (permalink / raw)
To: Robert Hancock; +Cc: linux-kernel, ide, Mike Cui, Peer Chen, Allen Martin
On 01/26/2010 11:33 PM, Robert Hancock wrote:
> Mike Cui reported that his system with an NVIDIA MCP79 (aka MCP7A) chipset
> stopped working with 2.6.32. The problem appears to be that 2.6.32 now enables
> the FPDMA auto-activate optimization in the ahci driver. The drive works fine
> with this enabled on an Intel AHCI so this appears to be a chipset bug.
> Since MCP79 is a fairly recent NVIDIA chipset and we don't have any info on
> whether any other NVIDIA chipsets have this issue, disable FPDMA AA optimization
> on all NVIDIA AHCI controllers for now.
>
> Should address http://bugzilla.kernel.org/show_bug.cgi?id=14922
>
> Signed-off-by: Robert Hancock<hancockrwd@gmail.com>
>
> ---
>
> Mike, can you test this out and make sure this resolves the problem for you?
Sigh... we never did hear back from Mike or NVIDIA on this one, did
we? I've been watching for a response, and haven't seen one to date.
Jeff
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ahci: disable FPDMA auto-activate optimization on NVIDIA AHCI
2010-02-13 22:46 ` Jeff Garzik
@ 2010-02-13 22:53 ` Robert Hancock
2010-02-13 23:02 ` Jeff Garzik
0 siblings, 1 reply; 9+ messages in thread
From: Robert Hancock @ 2010-02-13 22:53 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel, ide, Mike Cui, Peer Chen, Allen Martin
On Sat, Feb 13, 2010 at 4:46 PM, Jeff Garzik <jeff@garzik.org> wrote:
> On 01/26/2010 11:33 PM, Robert Hancock wrote:
>>
>> Mike Cui reported that his system with an NVIDIA MCP79 (aka MCP7A) chipset
>> stopped working with 2.6.32. The problem appears to be that 2.6.32 now
>> enables
>> the FPDMA auto-activate optimization in the ahci driver. The drive works
>> fine
>> with this enabled on an Intel AHCI so this appears to be a chipset bug.
>> Since MCP79 is a fairly recent NVIDIA chipset and we don't have any info
>> on
>> whether any other NVIDIA chipsets have this issue, disable FPDMA AA
>> optimization
>> on all NVIDIA AHCI controllers for now.
>>
>> Should address http://bugzilla.kernel.org/show_bug.cgi?id=14922
>>
>> Signed-off-by: Robert Hancock<hancockrwd@gmail.com>
>>
>> ---
>>
>> Mike, can you test this out and make sure this resolves the problem for
>> you?
>
> Sigh... we never did hear back from Mike or NVIDIA on this one, did we?
> I've been watching for a response, and haven't seen one to date.
No, I haven't seen a response. It's pretty apparent it should fix the
problem based on earlier testing, but it would be nice to find out for
sure which chipsets this affects.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ahci: disable FPDMA auto-activate optimization on NVIDIA AHCI
2010-02-13 22:53 ` Robert Hancock
@ 2010-02-13 23:02 ` Jeff Garzik
2010-02-15 18:34 ` Robert Hancock
0 siblings, 1 reply; 9+ messages in thread
From: Jeff Garzik @ 2010-02-13 23:02 UTC (permalink / raw)
To: Robert Hancock; +Cc: linux-kernel, ide, Mike Cui, Peer Chen, Allen Martin
On 02/13/2010 05:53 PM, Robert Hancock wrote:
> On Sat, Feb 13, 2010 at 4:46 PM, Jeff Garzik<jeff@garzik.org> wrote:
>> On 01/26/2010 11:33 PM, Robert Hancock wrote:
>>>
>>> Mike Cui reported that his system with an NVIDIA MCP79 (aka MCP7A) chipset
>>> stopped working with 2.6.32. The problem appears to be that 2.6.32 now
>>> enables
>>> the FPDMA auto-activate optimization in the ahci driver. The drive works
>>> fine
>>> with this enabled on an Intel AHCI so this appears to be a chipset bug.
>>> Since MCP79 is a fairly recent NVIDIA chipset and we don't have any info
>>> on
>>> whether any other NVIDIA chipsets have this issue, disable FPDMA AA
>>> optimization
>>> on all NVIDIA AHCI controllers for now.
>>>
>>> Should address http://bugzilla.kernel.org/show_bug.cgi?id=14922
>>>
>>> Signed-off-by: Robert Hancock<hancockrwd@gmail.com>
>>>
>>> ---
>>>
>>> Mike, can you test this out and make sure this resolves the problem for
>>> you?
>>
>> Sigh... we never did hear back from Mike or NVIDIA on this one, did we?
>> I've been watching for a response, and haven't seen one to date.
>
> No, I haven't seen a response. It's pretty apparent it should fix the
> problem based on earlier testing, but it would be nice to find out for
> sure which chipsets this affects.
Yep, that's my main concern... being overly aggressive and zapping it
on all NVIDIA chipsets, even future ones.
Jeff
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ahci: disable FPDMA auto-activate optimization on NVIDIA AHCI
2010-02-13 23:02 ` Jeff Garzik
@ 2010-02-15 18:34 ` Robert Hancock
0 siblings, 0 replies; 9+ messages in thread
From: Robert Hancock @ 2010-02-15 18:34 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel, ide, Mike Cui, Peer Chen, Allen Martin
On Sat, Feb 13, 2010 at 5:02 PM, Jeff Garzik <jeff@garzik.org> wrote:
>>>> Mike, can you test this out and make sure this resolves the problem for
>>>> you?
>>>
>>> Sigh... we never did hear back from Mike or NVIDIA on this one, did we?
>>> I've been watching for a response, and haven't seen one to date.
>>
>> No, I haven't seen a response. It's pretty apparent it should fix the
>> problem based on earlier testing, but it would be nice to find out for
>> sure which chipsets this affects.
>
> Yep, that's my main concern... being overly aggressive and zapping it on
> all NVIDIA chipsets, even future ones.
I'm thinking if we don't hear any more specifics on the problem from
NVIDIA or someone otherwise knowledgeable Real Soon Now we should
likely just merge this patch. MCP79 is a fairly new chipset and it's
likely a good assumption that the older NVIDIA AHCI chipsets would
have the same issue. It's possible that some of the newer chipsets do
or will fix the problem, but we can address that at a later date - the
auto-activate optimization is pretty minor and not worth breaking
things if there's doubt of it working on these controllers..
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ahci: disable FPDMA auto-activate optimization on NVIDIA AHCI
2010-01-27 4:33 [PATCH] ahci: disable FPDMA auto-activate optimization on NVIDIA AHCI Robert Hancock
2010-01-31 17:10 ` Robert Hancock
2010-02-13 22:46 ` Jeff Garzik
@ 2010-02-16 22:46 ` Prajakta Gudadhe
2010-02-24 0:39 ` Robert Hancock
2010-02-25 3:45 ` Jeff Garzik
3 siblings, 1 reply; 9+ messages in thread
From: Prajakta Gudadhe @ 2010-02-16 22:46 UTC (permalink / raw)
To: Robert Hancock, pgudadhe
Cc: linux-kernel, ide, Jeff Garzik, Mike Cui, Peer Chen
We are currently investigating this MCP79 issue when FPDMA auto activate
feature is enabled. Meanwhile, this patch looks good to me.
--Prajakta Gudadhe
On Tue, 2010-01-26 at 20:33 -0800, Robert Hancock wrote:
> Mike Cui reported that his system with an NVIDIA MCP79 (aka MCP7A) chipset
> stopped working with 2.6.32. The problem appears to be that 2.6.32 now enables
> the FPDMA auto-activate optimization in the ahci driver. The drive works fine
> with this enabled on an Intel AHCI so this appears to be a chipset bug.
> Since MCP79 is a fairly recent NVIDIA chipset and we don't have any info on
> whether any other NVIDIA chipsets have this issue, disable FPDMA AA optimization
> on all NVIDIA AHCI controllers for now.
>
> Should address http://bugzilla.kernel.org/show_bug.cgi?id=14922
>
> Signed-off-by: Robert Hancock <hancockrwd@gmail.com>
>
> ---
>
> Mike, can you test this out and make sure this resolves the problem for you?
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index b8bea10..47e57dc 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -3067,8 +3067,16 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> ahci_save_initial_config(pdev, hpriv);
>
> /* prepare host */
> - if (hpriv->cap & HOST_CAP_NCQ)
> - pi.flags |= ATA_FLAG_NCQ | ATA_FLAG_FPDMA_AA;
> + if (hpriv->cap & HOST_CAP_NCQ) {
> + pi.flags |= ATA_FLAG_NCQ;
> + /* Auto-activate optimization is supposed to be supported on
> + all AHCI controllers indicating NCQ support, but it seems
> + to be broken at least on some NVIDIA MCP79 chipsets.
> + Until we get info on which NVIDIA chipsets don't have this
> + issue, if any, disable AA on all NVIDIA AHCIs. */
> + if (pdev->vendor != PCI_VENDOR_ID_NVIDIA)
> + pi.flags |= ATA_FLAG_FPDMA_AA;
> + }
>
> if (hpriv->cap & HOST_CAP_PMP)
> pi.flags |= ATA_FLAG_PMP;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ide" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ahci: disable FPDMA auto-activate optimization on NVIDIA AHCI
2010-02-16 22:46 ` Prajakta Gudadhe
@ 2010-02-24 0:39 ` Robert Hancock
0 siblings, 0 replies; 9+ messages in thread
From: Robert Hancock @ 2010-02-24 0:39 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel, ide, Mike Cui, Peer Chen, Prajakta Gudadhe
Jeff, ping? Without further input from NVIDIA, I think we may want to
get this in for 2.6.33.
On Tue, Feb 16, 2010 at 4:46 PM, Prajakta Gudadhe <pgudadhe@nvidia.com> wrote:
> We are currently investigating this MCP79 issue when FPDMA auto activate
> feature is enabled. Meanwhile, this patch looks good to me.
>
> --Prajakta Gudadhe
>
> On Tue, 2010-01-26 at 20:33 -0800, Robert Hancock wrote:
>> Mike Cui reported that his system with an NVIDIA MCP79 (aka MCP7A) chipset
>> stopped working with 2.6.32. The problem appears to be that 2.6.32 now enables
>> the FPDMA auto-activate optimization in the ahci driver. The drive works fine
>> with this enabled on an Intel AHCI so this appears to be a chipset bug.
>> Since MCP79 is a fairly recent NVIDIA chipset and we don't have any info on
>> whether any other NVIDIA chipsets have this issue, disable FPDMA AA optimization
>> on all NVIDIA AHCI controllers for now.
>>
>> Should address http://bugzilla.kernel.org/show_bug.cgi?id=14922
>>
>> Signed-off-by: Robert Hancock <hancockrwd@gmail.com>
>>
>> ---
>>
>> Mike, can you test this out and make sure this resolves the problem for you?
>>
>> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
>> index b8bea10..47e57dc 100644
>> --- a/drivers/ata/ahci.c
>> +++ b/drivers/ata/ahci.c
>> @@ -3067,8 +3067,16 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>> ahci_save_initial_config(pdev, hpriv);
>>
>> /* prepare host */
>> - if (hpriv->cap & HOST_CAP_NCQ)
>> - pi.flags |= ATA_FLAG_NCQ | ATA_FLAG_FPDMA_AA;
>> + if (hpriv->cap & HOST_CAP_NCQ) {
>> + pi.flags |= ATA_FLAG_NCQ;
>> + /* Auto-activate optimization is supposed to be supported on
>> + all AHCI controllers indicating NCQ support, but it seems
>> + to be broken at least on some NVIDIA MCP79 chipsets.
>> + Until we get info on which NVIDIA chipsets don't have this
>> + issue, if any, disable AA on all NVIDIA AHCIs. */
>> + if (pdev->vendor != PCI_VENDOR_ID_NVIDIA)
>> + pi.flags |= ATA_FLAG_FPDMA_AA;
>> + }
>>
>> if (hpriv->cap & HOST_CAP_PMP)
>> pi.flags |= ATA_FLAG_PMP;
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ide" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
> -----------------------------------------------------------------------------------
> This email message is for the sole use of the intended recipient(s) and may contain
> confidential information. Any unauthorized review, use, disclosure or distribution
> is prohibited. If you are not the intended recipient, please contact the sender by
> reply email and destroy all copies of the original message.
> -----------------------------------------------------------------------------------
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ahci: disable FPDMA auto-activate optimization on NVIDIA AHCI
2010-01-27 4:33 [PATCH] ahci: disable FPDMA auto-activate optimization on NVIDIA AHCI Robert Hancock
` (2 preceding siblings ...)
2010-02-16 22:46 ` Prajakta Gudadhe
@ 2010-02-25 3:45 ` Jeff Garzik
3 siblings, 0 replies; 9+ messages in thread
From: Jeff Garzik @ 2010-02-25 3:45 UTC (permalink / raw)
To: Robert Hancock; +Cc: linux-kernel, ide, Mike Cui, Peer Chen
On 01/26/2010 11:33 PM, Robert Hancock wrote:
> Mike Cui reported that his system with an NVIDIA MCP79 (aka MCP7A) chipset
> stopped working with 2.6.32. The problem appears to be that 2.6.32 now enables
> the FPDMA auto-activate optimization in the ahci driver. The drive works fine
> with this enabled on an Intel AHCI so this appears to be a chipset bug.
> Since MCP79 is a fairly recent NVIDIA chipset and we don't have any info on
> whether any other NVIDIA chipsets have this issue, disable FPDMA AA optimization
> on all NVIDIA AHCI controllers for now.
>
> Should address http://bugzilla.kernel.org/show_bug.cgi?id=14922
>
> Signed-off-by: Robert Hancock<hancockrwd@gmail.com>
>
> ---
>
> Mike, can you test this out and make sure this resolves the problem for you?
applied
^ permalink raw reply [flat|nested] 9+ messages in thread