From: Damien Le Moal <dlemoal@kernel.org>
To: Rosen Penev <rosenp@gmail.com>, linux-ide@vger.kernel.org
Cc: Niklas Cassel <cassel@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ata: pata_ep93xx: add missing "cc" clobber to inline asm
Date: Tue, 21 Jul 2026 08:02:31 +0900 [thread overview]
Message-ID: <51f5420b-4eac-4f7e-9da6-727bc027bc23@kernel.org> (raw)
In-Reply-To: <CAKxU2N_Jwq4jqS7ckqBaXpAskeKtu4Giou7ssNvhhV8j7ROxBg@mail.gmail.com>
On 7/21/26 06:09, Rosen Penev wrote:
> On Mon, Jun 1, 2026 at 11:35 AM Rosen Penev <rosenp@gmail.com> wrote:
>>
>> The inline assembly in ep93xx_pata_delay() uses a "subs" instruction
>> which modifies the ARM condition code flags. Add a "cc" clobber so
>> the compiler knows the flags are altered. Without it, the compiler may
>> reorder flag-dependent instructions across the asm block when the
>> function is inlined, potentially causing incorrect control flow.
>>
>> Assisted-by: Opencode:Big-Pickle
>> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> should I resend?
Oops. This fell through the cracks. Yes, please resend and add a fixes tag as well.
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2026-07-20 23:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 18:34 [PATCH] ata: pata_ep93xx: add missing "cc" clobber to inline asm Rosen Penev
2026-07-20 21:09 ` Rosen Penev
2026-07-20 23:02 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51f5420b-4eac-4f7e-9da6-727bc027bc23@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox