From: Jens Axboe <axboe@kernel.dk>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: Tejun Heo <tj@kernel.org>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Mike Christie <michaelc@cs.wisc.edu>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Jeff Garzik <jgarzik@pobox.com>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing
Date: Fri, 09 Aug 2013 08:24:38 -0600 [thread overview]
Message-ID: <5204FBA6.6040001@kernel.dk> (raw)
In-Reply-To: <20130809082335.GA25306@dhcp-26-207.brq.redhat.com>
On 08/09/2013 02:23 AM, Alexander Gordeev wrote:
> On Mon, Jul 29, 2013 at 07:46:53AM -0400, Tejun Heo wrote:
>> One thing which would probably be worthwhile tho is getting rid of the
>> bitmap based qc tag allocator in libata. That one is just borderline
>> stupid to keep around on any setup which is supposed to be scalable.
>
> Hi Tejun,
>
> How about this approach?
>
> @@ -5639,6 +5627,12 @@ struct ata_port *ata_port_alloc(struct ata_host *host)
> if (!ap)
> return NULL;
>
> + ap->qc_tags = blk_mq_init_tags(ATA_MAX_QUEUE, 1, NUMA_NO_NODE);
> + if (!ap->qc_tags) {
> + kfree(ap);
> + return NULL;
> + }
This should be blk_mq_init_tags(ATA_MAX_QUEUE - 1, 1, ...) since the
total depth is normal_tags + reserved_tags. Apart from that, I think it
looks alright based on a cursory look.
--
Jens Axboe
next prev parent reply other threads:[~2013-08-09 14:26 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 19:00 [PATCH RESEND 0/1] AHCI: Optimize interrupt processing Alexander Gordeev
2013-05-21 19:00 ` [PATCH RESEND 1/1] " Alexander Gordeev
2013-05-21 23:50 ` [PATCH RESEND 0/1] " Tejun Heo
2013-05-22 14:39 ` Alexander Gordeev
2013-05-22 17:03 ` Jens Axboe
2013-07-11 10:26 ` Alexander Gordeev
2013-07-11 23:00 ` Nicholas A. Bellinger
2013-07-12 7:46 ` Alexander Gordeev
2013-07-13 5:20 ` Nicholas A. Bellinger
2013-07-16 18:32 ` Alexander Gordeev
2013-07-16 21:38 ` Nicholas A. Bellinger
2013-07-17 16:19 ` Alexander Gordeev
2013-07-18 18:51 ` Nicholas A. Bellinger
2013-07-18 19:12 ` Mike Christie
2013-07-19 0:23 ` Nicholas A. Bellinger
2013-07-19 0:30 ` Jens Axboe
2013-07-19 1:03 ` Nicholas A. Bellinger
2013-07-19 6:34 ` Nicholas A. Bellinger
2013-07-19 15:33 ` James Bottomley
2013-07-19 21:01 ` Nicholas A. Bellinger
2013-07-20 4:56 ` Nicholas A. Bellinger
2013-07-20 14:48 ` Mike Christie
2013-07-20 22:14 ` Nicholas A. Bellinger
2013-07-20 23:57 ` Jens Axboe
2013-08-09 19:15 ` Alexander Gordeev
2013-08-09 20:17 ` Nicholas A. Bellinger
2013-08-15 16:23 ` Alexander Gordeev
2013-08-16 2:19 ` Nicholas A. Bellinger
2013-08-16 16:41 ` Alexander Gordeev
2013-08-16 17:46 ` Nicholas A. Bellinger
2013-08-28 15:56 ` Alexander Gordeev
2013-09-20 15:19 ` Alexander Gordeev
2013-09-20 20:41 ` Nicholas A. Bellinger
2013-10-03 11:06 ` Christoph Hellwig
2013-10-07 14:44 ` Alexander Gordeev
2013-07-22 15:03 ` Alexander Gordeev
2013-07-22 21:10 ` Nicholas A. Bellinger
2013-07-25 10:16 ` Alexander Gordeev
2013-07-25 22:08 ` Nicholas A. Bellinger
2013-07-26 2:09 ` Jens Axboe
2013-07-26 21:14 ` Nicholas A. Bellinger
2013-07-27 0:43 ` Nicholas A. Bellinger
2013-07-29 11:18 ` Alexander Gordeev
2013-07-29 14:08 ` Jens Axboe
2013-07-29 19:19 ` Nicholas A. Bellinger
2013-07-31 4:16 ` Marc C
2013-07-31 10:23 ` Tejun Heo
2013-07-29 11:50 ` Tejun Heo
2013-07-29 19:11 ` Nicholas A. Bellinger
2013-07-29 11:46 ` Tejun Heo
2013-07-29 14:03 ` Jens Axboe
2013-08-09 8:23 ` Alexander Gordeev
2013-08-09 14:15 ` Tejun Heo
2013-08-09 14:24 ` Jens Axboe [this message]
2013-08-09 15:07 ` Alexander Gordeev
2013-08-09 15:52 ` Jens Axboe
2013-08-09 16:46 ` Alexander Gordeev
2013-08-09 17:07 ` Jens Axboe
2013-08-12 15:21 ` Alexander Gordeev
2013-07-29 7:28 ` Hannes Reinecke
2013-07-31 17:11 ` Alexander Gordeev
2013-07-19 15:58 ` Mike Christie
2013-07-19 21:05 ` Nicholas A. Bellinger
2013-07-18 19:14 ` Nicholas A. Bellinger
2013-07-18 21:21 ` Jens Axboe
2014-09-11 12:42 ` Alexander Gordeev
2014-09-11 12:44 ` [PATCH v2] " Alexander Gordeev
2014-09-13 4:43 ` Tejun Heo
2014-09-11 13:36 ` [PATCH RESEND 0/1] " Bartlomiej Zolnierkiewicz
2014-09-13 4:46 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5204FBA6.6040001@kernel.dk \
--to=axboe@kernel.dk \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agordeev@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=nab@linux-iscsi.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).