From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Marc C <marc.ceeeee@gmail.com>
Cc: tj@kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH v4 2/3] libata: Add support for SEND/RECEIVE FPDMA QUEUED
Date: Fri, 23 Aug 2013 16:43:37 +0400 [thread overview]
Message-ID: <521758F9.6040303@cogentembedded.com> (raw)
In-Reply-To: <1377250847-24132-3-git-send-email-marc.ceeeee@gmail.com>
Hello.
On 23-08-2013 13:40, Marc C wrote:
> From: Marc Carino <marc.ceeeee@gmail.com>
> Add support for the following ATA opcodes, which are present
> in SATA 3.1 and T13 ATA ACS-3:
> SEND FPDMA QUEUED
> RECEIVE FPDMA QUEUED
> Signed-off-by: Marc Carino <marc.ceeeee@gmail.com>
[...]
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 9062aa0..34ccadb 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -2141,6 +2141,26 @@ static int ata_dev_config_ncq(struct ata_device *dev,
> else
> snprintf(desc, desc_sz, "NCQ (depth %d/%d)%s", hdepth,
> ddepth, aa_desc);
> +
> + if ((ap->flags & ATA_FLAG_FPDMA_AUX) &&
> + ata_id_has_ncq_send_and_recv(dev->id)) {
Please start this line under the second ( above. It's the style preferred
in libata as it's easier on the eyes.
> + err_mask = ata_read_log_page(dev,
> + ATA_LOG_NCQ_SEND_RECV,
> + 0,
> + ap->sector_buf,
> + 1);
> + if (err_mask) {
> + ata_dev_dbg(dev,
> + "failed to get NCQ Send/Recv Log "
> + "Emask 0x%x\n",
> + err_mask);
> + } else {
> + dev->flags |= ATA_DFLAG_NCQ_SEND_RECV;
> + memcpy(dev->ncq_send_recv_cmds, ap->sector_buf,
> + ATA_LOG_NCQ_SEND_RECV_SIZE);
> + }
> + }
> +
WBR, Sergei
next prev parent reply other threads:[~2013-08-23 12:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 9:40 [PATCH v4 0/3] Introduce new SATA queued commands Marc C
2013-08-23 9:40 ` [PATCH v4 1/3] libata: Populate host-to-device FIS "auxiliary" field Marc C
2013-08-23 12:27 ` Sergei Shtylyov
2013-08-23 9:40 ` [PATCH v4 2/3] libata: Add support for SEND/RECEIVE FPDMA QUEUED Marc C
2013-08-23 12:43 ` Sergei Shtylyov [this message]
2013-08-23 16:06 ` Tejun Heo
2013-08-23 9:40 ` [PATCH v4 3/3] libata: Add support for queued DSM TRIM Marc C
2013-08-23 16:07 ` Tejun Heo
2013-08-23 16:08 ` [PATCH v4 0/3] Introduce new SATA queued commands Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521758F9.6040303@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-ide@vger.kernel.org \
--cc=marc.ceeeee@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).