From: Damien Le Moal <dlemoal@kernel.org>
To: Igor Pylypiv <ipylypiv@google.com>
Cc: linux-ide@vger.kernel.org, Niklas Cassel <cassel@kernel.org>,
Xingui Yang <yangxingui@huawei.com>
Subject: Re: [PATCH 2/2] ata: libata-scsi: avoid passthrough command starvation
Date: Fri, 19 Dec 2025 16:47:16 +0900 [thread overview]
Message-ID: <521d6ca5-5d80-44ee-acef-fb1887deb9e9@kernel.org> (raw)
In-Reply-To: <aUSXeEoBg1cYYdtK@google.com>
On 12/19/25 09:08, Igor Pylypiv wrote:
>> static int ata_scsi_defer(struct ata_port *ap, struct ata_queued_cmd *qc)
>> {
>> int ret;
>>
>> + /*
>> + * If we already have a deferred QC, then rely on the SCSI layer to
>> + * defer and requeue all incoming commands until the deferred QC is
>> + * processed, once all on-going commands are completed.
>> + */
>> + if (ap->deferred_qc)
>> + return SCSI_MLQUEUE_DEVICE_BUSY;
>
> Should we free qc here? ata_scsi_translate() does not free qc if
> ata_scsi_defer() returns a non-zero value.
Good catch ! Sending V2.
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2025-12-19 7:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 23:17 [PATCH 0/2] Prevent non-NCQ command starvation Damien Le Moal
2025-12-17 23:17 ` [PATCH 1/2] ata: libata-scsi: refactor ata_scsi_translate() Damien Le Moal
2025-12-18 9:23 ` Hannes Reinecke
2025-12-17 23:17 ` [PATCH 2/2] ata: libata-scsi: avoid passthrough command starvation Damien Le Moal
2025-12-18 9:26 ` Hannes Reinecke
2025-12-19 0:08 ` Igor Pylypiv
2025-12-19 7:47 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521d6ca5-5d80-44ee-acef-fb1887deb9e9@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=ipylypiv@google.com \
--cc=linux-ide@vger.kernel.org \
--cc=yangxingui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox