From: Levente Kurusa <levex@linux.com>
To: Tejun Heo <tj@kernel.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH v2] ata_piix: minor typo and a printk fix
Date: Tue, 01 Oct 2013 19:39:24 +0200 [thread overview]
Message-ID: <524B08CC.7010604@linux.com> (raw)
In-Reply-To: <20130930193628.GA8091@htj.dyndns.org>
2013-09-30 21:36 keltezéssel, Tejun Heo írta:
> Hello,
>
> Tried to apply it but patch seems whitespace damaged and doesn't
> apply. Please resend. Also, one comment.
>
> On Fri, Sep 27, 2013 at 04:15:36PM +0200, Levente Kurusa wrote:
>> - ICH5_PMR = 0x90, /* port mapping register */
>> + ICH5_PMR = 0x90, /* address map register */
>
> I don't know whether the name has changed but PMR at least did stand
> for Port Mapping Register. I don't see much point in updating the
> comment here.
>
> Thanks.
>
According to the specifications of ICH5, it is called
Address Map Register. I didn't want to change the variable's name,
because I think it would cause some headaches for those wanting to find
information on google.
http://www.intel.com/content/dam/doc/datasheet/82801eb-82801er-io-controller-hub-datasheet.pdf
See Chapter 11.1.32
The patch gets whitespace damaged due to Thunderbird, I will experiment
before resending it again.
--
Regards,
Levente Kurusa
prev parent reply other threads:[~2013-10-01 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 14:15 [PATCH v2] ata_piix: minor typo and a printk fix Levente Kurusa
2013-09-30 19:36 ` Tejun Heo
2013-10-01 17:39 ` Levente Kurusa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524B08CC.7010604@linux.com \
--to=levex@linux.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).