* [PATCH 1/2] ahci: use dev_info() instead of printk()
@ 2013-10-04 5:19 Jingoo Han
2013-10-04 5:20 ` [PATCH 2/2] ahci_platform: " Jingoo Han
2013-10-04 20:18 ` [PATCH 1/2] ahci: " Sergei Shtylyov
0 siblings, 2 replies; 5+ messages in thread
From: Jingoo Han @ 2013-10-04 5:19 UTC (permalink / raw)
To: 'Tejun Heo'; +Cc: linux-ide, 'Jingoo Han'
Use the printk(KERN_INFO,...) call to to dev_info() instead,
to tie into the dynamic debugging infrastructure.
Also change "raw" printk() call to dev_info() to provide a better
error message to userspace so it can properly identify the device
and not just have to guess.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Tested on Exynos5440.
drivers/ata/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 9d715ae..8e28f92 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1343,7 +1343,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
host->flags |= ATA_HOST_PARALLEL_SCAN;
else
- printk(KERN_INFO "ahci: SSS flag set, parallel bus scan disabled\n");
+ dev_info(&pdev->dev, "SSS flag set, parallel bus scan disabled\n");
if (pi.flags & ATA_FLAG_EM)
ahci_reset_em(host);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] ahci_platform: use dev_info() instead of printk()
2013-10-04 5:19 [PATCH 1/2] ahci: use dev_info() instead of printk() Jingoo Han
@ 2013-10-04 5:20 ` Jingoo Han
2013-10-04 20:19 ` Sergei Shtylyov
2013-10-04 20:18 ` [PATCH 1/2] ahci: " Sergei Shtylyov
1 sibling, 1 reply; 5+ messages in thread
From: Jingoo Han @ 2013-10-04 5:20 UTC (permalink / raw)
To: 'Tejun Heo'; +Cc: linux-ide, 'Jingoo Han'
Use the printk(KERN_INFO,...) call to to dev_info() instead,
to tie into the dynamic debugging infrastructure.
Also change "raw" printk() call to dev_info() to provide a better
error message to userspace so it can properly identify the device
and not just have to guess.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Tested on Exynos5440.
drivers/ata/ahci_platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c
index 2daaee0..7d3b853 100644
--- a/drivers/ata/ahci_platform.c
+++ b/drivers/ata/ahci_platform.c
@@ -184,7 +184,7 @@ static int ahci_probe(struct platform_device *pdev)
if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
host->flags |= ATA_HOST_PARALLEL_SCAN;
else
- printk(KERN_INFO "ahci: SSS flag set, parallel bus scan disabled\n");
+ dev_info(dev, "SSS flag set, parallel bus scan disabled\n");
if (pi.flags & ATA_FLAG_EM)
ahci_reset_em(host);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ahci: use dev_info() instead of printk()
2013-10-04 5:19 [PATCH 1/2] ahci: use dev_info() instead of printk() Jingoo Han
2013-10-04 5:20 ` [PATCH 2/2] ahci_platform: " Jingoo Han
@ 2013-10-04 20:18 ` Sergei Shtylyov
2013-10-05 0:04 ` Jingoo Han
1 sibling, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2013-10-04 20:18 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Tejun Heo', linux-ide
Hello.
On 04-10-2013 7:19, Jingoo Han wrote:
> Use the printk(KERN_INFO,...) call to to dev_info() instead,
> to tie into the dynamic debugging infrastructure.
I can't even parse this sentence, not to mention dev_info() has no
relation to dynamic debugging.
> Also change "raw" printk() call to dev_info() to provide a better
> error message to userspace so it can properly identify the device
> and not just have to guess.
I'm only seeing the second change in your patch.
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
[...]
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 9d715ae..8e28f92 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1343,7 +1343,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
> host->flags |= ATA_HOST_PARALLEL_SCAN;
> else
> - printk(KERN_INFO "ahci: SSS flag set, parallel bus scan disabled\n");
> + dev_info(&pdev->dev, "SSS flag set, parallel bus scan disabled\n");
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] ahci_platform: use dev_info() instead of printk()
2013-10-04 5:20 ` [PATCH 2/2] ahci_platform: " Jingoo Han
@ 2013-10-04 20:19 ` Sergei Shtylyov
0 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2013-10-04 20:19 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Tejun Heo', linux-ide
On 04-10-2013 7:20, Jingoo Han wrote:
> Use the printk(KERN_INFO,...) call to to dev_info() instead,
> to tie into the dynamic debugging infrastructure.
> Also change "raw" printk() call to dev_info() to provide a better
> error message to userspace so it can properly identify the device
> and not just have to guess.
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Same comments to this patch.
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ahci: use dev_info() instead of printk()
2013-10-04 20:18 ` [PATCH 1/2] ahci: " Sergei Shtylyov
@ 2013-10-05 0:04 ` Jingoo Han
0 siblings, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2013-10-05 0:04 UTC (permalink / raw)
To: 'Sergei Shtylyov'
Cc: 'Tejun Heo', linux-ide, 'Jingoo Han'
On Saturday, October 05, 2013 5:18 AM, Sergei Shtylyov wrote:
> On 04-10-2013 7:19, Jingoo Han wrote:
>
> > Use the printk(KERN_INFO,...) call to to dev_info() instead,
> > to tie into the dynamic debugging infrastructure.
>
> I can't even parse this sentence, not to mention dev_info() has no
> relation to dynamic debugging.
Hi Sergei Shtylyov,
Right, dev_info() is not related to the dynamic debugging.
I will remove this comment from commit message.
Thank you for your comment. :-)
Best regards,
Jingoo Han
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-05 0:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-04 5:19 [PATCH 1/2] ahci: use dev_info() instead of printk() Jingoo Han
2013-10-04 5:20 ` [PATCH 2/2] ahci_platform: " Jingoo Han
2013-10-04 20:19 ` Sergei Shtylyov
2013-10-04 20:18 ` [PATCH 1/2] ahci: " Sergei Shtylyov
2013-10-05 0:04 ` Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).