From: Aaron Lu <aaron.lu@intel.com>
To: Phillip Susi <psusi@ubuntu.com>,
Alan Stern <stern@rowland.harvard.edu>,
Jens Axboe <axboe@kernel.dk>, "Rafael J. Wysocki" <rjw@sisk.pl>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Tejun Heo <tj@kernel.org>
Cc: linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Aaron Lu <aaron.lwe@gmail.com>, Shane Huang <shane.huang@amd.com>,
Oliver Neukum <oneukum@suse.de>
Subject: Re: block layer runtime pm and udisks
Date: Thu, 10 Oct 2013 09:52:57 +0800 [thread overview]
Message-ID: <52560879.8000001@intel.com> (raw)
In-Reply-To: <5256058F.3010802@ubuntu.com>
On 10/10/2013 09:40 AM, Phillip Susi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> I have been trying out the new block layer runtime pm, and run into a
> problem: udisks keeps waking up the disk. Every 10 minutes it tries
> to poll the SMART status of the drive, but it does first issue an ata
> CHECK POWER command to see if it is in standby, and skips the check to
> avoid waking the disk. The problem with runtime pm is that *any*
> request brings the drive out of suspend, and the suspend wake path
> forces the drive to spin up by issuing a verify command on sector 0.
>
> Is there a reason that the wakeup path forces the drive to spin up, or
> could this be removed and rely on the drive waking up automatically if
> the request requires it?
>
> Or would it be possible to notice that the command being sent is a
> check power command, and fake the reply instead of resuming the device?
>
> Or does udisks just need to check the runtime pm status before trying
> the check power command?
I think the udisks can be modified to check if the drive is runtime
suspended and if so, avoid poll the SMART status.
Thanks,
Aaron
>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.14 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQEcBAEBCgAGBQJSVgWPAAoJEJrBOlT6nu75k/cH+gMAb9YtMS21rEt94umJpBYj
> BcNoyGoK39tAKZHW7pXfP2hRIm1+kPTPi44Wp7kQHu7m6BSp4YetmDkqjNv+6yAy
> 8SUvPcqRsJVbF1oBXN09phBEnk/JfxqID7n6hB1lT6NqYV72VVVUEUOlnSnpHtDJ
> gszV+TLH37uhd5/KiDFja3J2bJC0R/klzDF1x1clc53tGJd1NZ+h9tZZBLszIdnS
> EnjukLA02Q7ooq+445WyWth2cypTXKfRbigZW+FfCI3hfAKOShVevodlGmmrQb7Z
> 0xzhSoO5JTpNqJPLaNL3+JZFdXwANd+7PuO9v2XVKKUkydQ9+Vl4CfydSFhqo5U=
> =iuSZ
> -----END PGP SIGNATURE-----
>
prev parent reply other threads:[~2013-10-10 1:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-23 3:42 [PATCH v12 0/5] block layer runtime pm Aaron Lu
2013-03-23 3:42 ` [PATCH v12 1/5] block: add a flag to identify PM request Aaron Lu
2013-03-23 3:42 ` [PATCH v12 2/5] scsi: use REQ_PM in sd's runtime suspend operation Aaron Lu
2013-03-23 3:42 ` [PATCH v12 3/5] block: add runtime pm helpers Aaron Lu
2013-03-23 3:42 ` [PATCH v12 4/5] block: implement runtime pm strategy Aaron Lu
2013-03-23 3:42 ` [PATCH v12 5/5] sd: change to auto suspend mode Aaron Lu
2013-03-23 4:23 ` [PATCH v12 0/5] block layer runtime pm Jens Axboe
2013-03-28 8:54 ` Aaron Lu
2013-10-10 1:40 ` block layer runtime pm and udisks Phillip Susi
2013-10-10 1:52 ` Aaron Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52560879.8000001@intel.com \
--to=aaron.lu@intel.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=aaron.lwe@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=psusi@ubuntu.com \
--cc=rjw@sisk.pl \
--cc=shane.huang@amd.com \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).