From: Valentine <valentine.barshak@cogentembedded.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Kumar Gala <galak@codeaurora.org>, Tejun Heo <tj@kernel.org>
Cc: linux-sh@vger.kernel.org, linux-ide@vger.kernel.org,
devicetree@vger.kernel.org, Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Vladimir Barinov <vladimir.barinov@cogentembedded.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH V3 2/2] dt: Document sata_rcar bindings
Date: Sat, 09 Nov 2013 00:30:45 +0400 [thread overview]
Message-ID: <527D49F5.9030704@cogentembedded.com> (raw)
In-Reply-To: <3353398.KxY2PdxubL@avalon>
On 11/08/2013 06:30 PM, Laurent Pinchart wrote:
> Hi Kumar,
>
> On Friday 08 November 2013 08:26:47 Kumar Gala wrote:
>> On Nov 8, 2013, at 6:09 AM, Valentine Barshak wrote:
>>> These bindings can be used to register SATA devices found on R-Car SoC.
>>>
>>> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
>>> ---
>>> Documentation/devicetree/bindings/ata/sata_rcar.txt | 18 +++++++++++++++++
>>> 1 file changed, 18 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/ata/sata_rcar.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/ata/sata_rcar.txt
>>> b/Documentation/devicetree/bindings/ata/sata_rcar.txt new file mode
>>> 100644
>>> index 0000000..1e61113
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/ata/sata_rcar.txt
>>> @@ -0,0 +1,18 @@
>>> +* Renesas R-Car SATA
>>> +
>>> +Required properties:
>>> +- compatible : should contain one of the following:
>>> + - "renesas,sata-r8a7779" for R-Car H1
>>> + - "renesas,sata-r8a7790" for R-Car H2
>>> + - "renesas,sata-r8a7791" for R-Car M2
>>> +- reg : address and length of the SATA registers;
>>> +- interrupts : must consist of one interrupt specifier.
>>> +
>>> +Example:
>>> +
>>> +sata: sata@fc600000 {
>>> + compatible = "renesas,sata-r8a7779";
>>> + reg = <0xfc600000 0x2000>;
>>> + interrupt-parent = <&gic>;
>>> + interrupts = <0 100 IRQ_TYPE_LEVEL_HIGH>;
>>
>> Sorry, I missed the discussion on this, but I think it would be better in
>> the example to leave this as 4. There is no reference in the binding at
>> all to figure out where IRQ_TYPE_LEVEL_HIGH is defined.
>
> Then I'd rather reference the interrupts binding document, otherwise people
> will blindly write device tree sources with 4 instead of IRQ_TYPE_LEVEL_HIGH,
> which I don't want to encourage.
>
>>> +};
Is it possible to get the functional SATA phy changes from the first patch applied
and have a separate discussion regarding DT bindings?
This DT discussion is not related to the SATA PHY changes.
There were comments to keep both patches as a single series, but I don't see any reason
for that anymore.
Thanks,
Val.
next prev parent reply other threads:[~2013-11-08 20:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 12:09 [PATCH V3 0/2] sata_rcar: Add Gen2 PHY support and document existing DT bindings Valentine Barshak
2013-11-08 12:09 ` [PATCH V3 1/2] sata_rcar: Add R-Car Gen2 SATA PHY support Valentine Barshak
2013-11-26 22:06 ` Valentine
2013-11-29 20:14 ` Tejun Heo
2013-11-29 20:35 ` Valentine
2013-11-29 20:42 ` Tejun Heo
2013-12-02 0:02 ` Simon Horman
2013-12-02 10:07 ` Valentine
2013-11-08 12:09 ` [PATCH V3 2/2] dt: Document sata_rcar bindings Valentine Barshak
2013-11-08 14:26 ` Kumar Gala
2013-11-08 14:30 ` Laurent Pinchart
2013-11-08 20:30 ` Valentine [this message]
2013-12-02 19:55 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527D49F5.9030704@cogentembedded.com \
--to=valentine.barshak@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=g.liakhovetski@gmx.de \
--cc=galak@codeaurora.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tj@kernel.org \
--cc=vladimir.barinov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).