From: Roland Dreier <roland@topspin.com>
To: Prakash Punnoor <prakashp@arcor.de>
Cc: Alexey Dobriyan <adobriyan@mail.ru>,
Jeff Garzik <jgarzik@pobox.com>, Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@osdl.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Mark Lord <mlord@pobox.com>
Subject: Re: [BK PATCHES] 2.6.x libata fixes (mostly)
Date: Wed, 23 Feb 2005 14:01:44 -0800 [thread overview]
Message-ID: <528y5faqbb.fsf@topspin.com> (raw)
In-Reply-To: <421CF575.20801@arcor.de> (Prakash Punnoor's message of "Wed, 23 Feb 2005 22:28:21 +0100")
Prakash> If I am not totally mistaken this is not gcc4 friendly
Prakash> code. (lvalue thing...)
Actually you misread the code slightly. It's a little subtle, but
code like
*(__le32 *)prd = cpu_to_le32(len);
is not using a cast as an lvalue. It's dereferencing a cast and as
such is totally correct, idiomatic and clean C.
- Roland
next prev parent reply other threads:[~2005-02-23 22:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-23 19:57 [BK PATCHES] 2.6.x libata fixes (mostly) Jeff Garzik
2005-02-23 21:45 ` Alexey Dobriyan
2005-02-23 21:24 ` Jeff Garzik
2005-02-23 21:28 ` Prakash Punnoor
2005-02-23 22:01 ` Roland Dreier [this message]
2005-02-23 22:07 ` Prakash Punnoor
2005-02-23 21:57 ` Alexey Dobriyan
2005-02-23 23:26 ` [PATCH 2.6.11+ sata_qstor] libata: sata_qstor cosmetic fixes Mark Lord
2005-02-23 23:39 ` Jeff Garzik
2005-02-24 5:21 ` Jeff Garzik
2005-02-24 15:15 ` Mark Lord
2005-02-25 5:48 ` Jeff Garzik
2005-02-28 16:22 ` [PATCH 2.6.11-rc5+ sata_qstor] sata_qstor: eh_timeout fix Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528y5faqbb.fsf@topspin.com \
--to=roland@topspin.com \
--cc=adobriyan@mail.ru \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlord@pobox.com \
--cc=prakashp@arcor.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).