Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Yijing Wang <wangyijing@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 3/4] ata: Fix acpi_bus_get_device() return value check
Date: Mon, 25 Nov 2013 09:34:27 +0800	[thread overview]
Message-ID: <5292A923.6040409@huawei.com> (raw)
In-Reply-To: <CAOS58YNk9DLx-Ps7CYSrMjsbUf68tbHvqsyYbwjWg8c8KkajEw@mail.gmail.com>

On 2013/11/23 6:39, Tejun Heo wrote:
> On Wed, Nov 20, 2013 at 4:28 AM, Yijing Wang <wangyijing@huawei.com> wrote:
>> Since acpi_bus_get_device() returns plain int and not acpi_status,
>> ACPI_FAILURE() should not be used for checking its return value.  Fix
>> that.
>>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> Cc: Tejun Heo <tj@kernel.org>
>> Cc: linux-ide@vger.kernel.org
> 
> Applied to libata/for-3.13-fixes.  Thanks.

Hi Tejun,
   Sorry for disturb you, this patch has a build warning found by linux-next kbuild test.

All warnings:

   drivers/ata/libata-zpodd.c: In function 'odd_can_poweroff':
>> drivers/ata/libata-zpodd.c:91:14: warning: unused variable 'status' [-Wunused-variable]
     acpi_status status;


So I send a new patch "[PATCH v2] ata: Fix acpi_bus_get_device() return value check" to you,
can you help to update it.


Thanks!
Yijing.



  reply	other threads:[~2013-11-25  1:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1384939706-6292-1-git-send-email-wangyijing@huawei.com>
2013-11-20  9:28 ` [PATCH 3/4] ata: Fix acpi_bus_get_device() return value check Yijing Wang
2013-11-21  8:30   ` Aaron Lu
2013-11-22 22:39   ` Tejun Heo
2013-11-25  1:34     ` Yijing Wang [this message]
2013-11-25 15:58       ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5292A923.6040409@huawei.com \
    --to=wangyijing@huawei.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox