From: Aaron Lu <aaron.lu@intel.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/3] libata: acpi: avoid passing NULL to ACPI evaluation method
Date: Fri, 14 Mar 2014 22:32:08 +0800 [thread overview]
Message-ID: <532312E8.4020001@intel.com> (raw)
In-Reply-To: <5323115A.7050200@intel.com>
On 03/14/2014 10:25 PM, Aaron Lu wrote:
> On 03/14/2014 08:58 PM, Tejun Heo wrote:
>> On Fri, Mar 14, 2014 at 01:46:09PM +0800, Aaron Lu wrote:
>>> If ACPI handle for an ATA device is NULL, we shouldn't call
>>> ata_dev_get_GTF as that function will use handle to do some ACPI
>>> evaluation.
>>
>> This caused a crash, right? Can you please include what can trigger
>> such oops and how it looks like and reference to the original bug
>> report. In general, when you're cc'ing stable, please try to provide
>> as much information about the bug as possible so that downstreams have
>> easier time evaluating the importance and risk of the change. The
>> same goes for the previous patch.
>
> For the 1/3 patch, no crash either. It's just that if CONFIG_PM_RUNTIME
> is not set, ZPODD will not function so building it doesn't make sense.
No bug report for this either, I realized this when I'm preparing a test
build for !CONFIG_PM_RUNTIME and found that I can still select ZPODD.
next prev parent reply other threads:[~2014-03-14 14:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 5:46 [PATCH 0/3] ata: acpi/zpodd: some small fixes Aaron Lu
2014-03-14 5:46 ` [PATCH 1/3] libata: zpodd: should depend on PM_RUNTIME Aaron Lu
2014-03-14 5:46 ` [PATCH 2/3] libata: acpi: avoid passing NULL to ACPI evaluation method Aaron Lu
2014-03-14 12:58 ` Tejun Heo
2014-03-14 14:25 ` Aaron Lu
2014-03-14 14:32 ` Aaron Lu [this message]
2014-03-14 14:33 ` Tejun Heo
2014-03-14 15:18 ` Aaron Lu
2014-03-14 5:46 ` [PATCH 3/3] libata: zpodd: eliminate odd_can_poweroff Aaron Lu
2014-03-14 15:24 ` [PATCH 0/3] ata: acpi/zpodd: some small fixes Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532312E8.4020001@intel.com \
--to=aaron.lu@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).