Re: [PATCH 2/3] libata: acpi: avoid passing NULL to ACPI evaluation method

[Aaron Lu <aaron.lu@intel.com>]

On 03/14/2014 10:33 PM, Tejun Heo wrote:
> On Fri, Mar 14, 2014 at 10:32:08PM +0800, Aaron Lu wrote:
>> On 03/14/2014 10:25 PM, Aaron Lu wrote:
>>> On 03/14/2014 08:58 PM, Tejun Heo wrote:
>>>> On Fri, Mar 14, 2014 at 01:46:09PM +0800, Aaron Lu wrote:
>>>>> If ACPI handle for an ATA device is NULL, we shouldn't call
>>>>> ata_dev_get_GTF as that function will use handle to do some ACPI
>>>>> evaluation.
>>>>
>>>> This caused a crash, right?  Can you please include what can trigger
>>>> such oops and how it looks like and reference to the original bug
>>>> report.  In general, when you're cc'ing stable, please try to provide
>>>> as much information about the bug as possible so that downstreams have
>>>> easier time evaluating the importance and risk of the change.  The
>>>> same goes for the previous patch.
>>>
>>> For the 1/3 patch, no crash either. It's just that if CONFIG_PM_RUNTIME
>>> is not set, ZPODD will not function so building it doesn't make sense.
>>
>> No bug report for this either, I realized this when I'm preparing a test
>> build for !CONFIG_PM_RUNTIME and found that I can still select ZPODD.
>
> Both aren't really -stable material then, right?

Yes.