From: Jens Axboe <axboe@kernel.dk>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Hannes Reinecke <hare@suse.de>, Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] sata_fsl: build fix
Date: Wed, 25 Mar 2020 10:31:16 -0600 [thread overview]
Message-ID: <53445c8e-2395-4f5f-3760-9715f34d3fcc@kernel.dk> (raw)
In-Reply-To: <5e52900b-6674-4220-15e4-8156ebd98df5@samsung.com>
On 3/25/20 10:25 AM, Bartlomiej Zolnierkiewicz wrote:
>
> On 3/25/20 4:17 PM, Jens Axboe wrote:
>> On 3/25/20 9:15 AM, Bartlomiej Zolnierkiewicz wrote:
>>> Fix incorrect DPRINTK() conversion in sata_fsl_init_controller()
>>> (dev_dbg() should be used instead of ata_port_dbg()).
>>
>> Thanks Bart, another piece of fallout. Applied.
>>
>> With the recent discussion as well, I wonder if we should just kill
>> this series entirely.
> I hate to admit it but probably yes..
>
> It seems that the one of base concepts needs to be redesigned and
> we are at -rc7 so it is a bit too late do it now..
>
> I've also tried to find a way to revert it partially but changes are
> inter-dependent and it doesn't seem to be easy way to do it..
>
> Hannes?
I've killed it, we can always try again later, if we have to.
--
Jens Axboe
next prev parent reply other threads:[~2020-03-25 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200325151525eucas1p1870a02b81ef13a8e449b0dfbabd0fe81@eucas1p1.samsung.com>
2020-03-25 15:15 ` [PATCH] sata_fsl: build fix Bartlomiej Zolnierkiewicz
2020-03-25 15:17 ` Jens Axboe
2020-03-25 16:25 ` Bartlomiej Zolnierkiewicz
2020-03-25 16:31 ` Jens Axboe [this message]
2020-03-25 17:01 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53445c8e-2395-4f5f-3760-9715f34d3fcc@kernel.dk \
--to=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox