[PATCH] sata_fsl: build fix

[PATCH] sata_fsl: build fix

[Bartlomiej Zolnierkiewicz]

Fix incorrect DPRINTK() conversion in sata_fsl_init_controller()
(dev_dbg() should be used instead of ata_port_dbg()).

Fixes: b3f062310706 ("sata_fsl: move DPRINTK to ata debugging")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Reported-by: kbuild test robot <lkp@intel.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
 drivers/ata/sata_fsl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/ata/sata_fsl.c
===================================================================
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -1362,7 +1362,7 @@ static int sata_fsl_init_controller(stru
 	iowrite32((temp & ~0x3F), hcr_base + HCONTROL);
 
 	/* Disable interrupt coalescing control(icc), for the moment */
-	ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
+	dev_dbg(host->dev, "icc = 0x%x\n", ioread32(hcr_base + ICC));
 	iowrite32(0x01000000, hcr_base + ICC);
 
 	/* clear error registers, SError is cleared by libATA  */

Re: [PATCH] sata_fsl: build fix

[Jens Axboe]

On 3/25/20 9:15 AM, Bartlomiej Zolnierkiewicz wrote:
> Fix incorrect DPRINTK() conversion in sata_fsl_init_controller()
> (dev_dbg() should be used instead of ata_port_dbg()).

Thanks Bart, another piece of fallout. Applied.

With the recent discussion as well, I wonder if we should just kill
this series entirely.

-- 
Jens Axboe

Re: [PATCH] sata_fsl: build fix

[Bartlomiej Zolnierkiewicz]

On 3/25/20 4:17 PM, Jens Axboe wrote:
> On 3/25/20 9:15 AM, Bartlomiej Zolnierkiewicz wrote:
>> Fix incorrect DPRINTK() conversion in sata_fsl_init_controller()
>> (dev_dbg() should be used instead of ata_port_dbg()).
> 
> Thanks Bart, another piece of fallout. Applied.
> 
> With the recent discussion as well, I wonder if we should just kill
> this series entirely.
I hate to admit it but probably yes..

It seems that the one of base concepts needs to be redesigned and
we are at -rc7 so it is a bit too late do it now..

I've also tried to find a way to revert it partially but changes are
inter-dependent and it doesn't seem to be easy way to do it..

Hannes?

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Re: [PATCH] sata_fsl: build fix

[Jens Axboe]

On 3/25/20 10:25 AM, Bartlomiej Zolnierkiewicz wrote:
> 
> On 3/25/20 4:17 PM, Jens Axboe wrote:
>> On 3/25/20 9:15 AM, Bartlomiej Zolnierkiewicz wrote:
>>> Fix incorrect DPRINTK() conversion in sata_fsl_init_controller()
>>> (dev_dbg() should be used instead of ata_port_dbg()).
>>
>> Thanks Bart, another piece of fallout. Applied.
>>
>> With the recent discussion as well, I wonder if we should just kill
>> this series entirely.
> I hate to admit it but probably yes..
> 
> It seems that the one of base concepts needs to be redesigned and
> we are at -rc7 so it is a bit too late do it now..
> 
> I've also tried to find a way to revert it partially but changes are
> inter-dependent and it doesn't seem to be easy way to do it..
> 
> Hannes?

I've killed it, we can always try again later, if we have to.

-- 
Jens Axboe

Re: [PATCH] sata_fsl: build fix

[Hannes Reinecke]

On 3/25/20 5:25 PM, Bartlomiej Zolnierkiewicz wrote:
> 
> On 3/25/20 4:17 PM, Jens Axboe wrote:
>> On 3/25/20 9:15 AM, Bartlomiej Zolnierkiewicz wrote:
>>> Fix incorrect DPRINTK() conversion in sata_fsl_init_controller()
>>> (dev_dbg() should be used instead of ata_port_dbg()).
>>
>> Thanks Bart, another piece of fallout. Applied.
>>
>> With the recent discussion as well, I wonder if we should just kill
>> this series entirely.
> I hate to admit it but probably yes..
> 
> It seems that the one of base concepts needs to be redesigned and
> we are at -rc7 so it is a bit too late do it now..
> 
> I've also tried to find a way to revert it partially but changes are
> inter-dependent and it doesn't seem to be easy way to do it..
> 
> Hannes?
> 
Seeing that we are late in the game and the dev_printk() fallacies are 
indeed there I fear that you are correct.
Jens, again, sorry for the mess.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke            Teamlead Storage & Networking
hare@suse.de                               +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer