Re: [PATCH V2 2/2] ahci: add support for Hisilicon sata

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 04/16/2014 10:49 PM, Tejun Heo wrote:
> Hello,
> 
> On Thu, Apr 10, 2014 at 01:24:28PM +0800, Kefeng Wang wrote:
>> From: Kefeng Wang <kefeng.wang@linaro.org>
>>
>> The hip04 SoC of hisilicon has an AHCI compliant SATA controller,
>> and it is compliant with the ahci 1.3 and sata 3.0 specification.
>>
>> There is a wrong bit in HOST_CAP of hip04 sata controller, which
>> enable unsupported feature of FBS, use AHCI_HFLAG_NO_FBS hflag to
>> disable it.
>>
>> Cc: Hans de Geode <hdegoede@redhat.com>
>> Signed-off-by: Kefeng Wang <kefeng.wang@linaro.org>
>> @@ -54,8 +55,10 @@ static int ahci_probe(struct platform_device *pdev)
>>  		if (rc)
>>  			goto disable_resources;
>>  	}
>> +	if (of_device_is_compatible(pdev->dev.of_node, "hisilicon,hisi-ahci"))
>> +		pi.private_data = (void *)AHCI_HFLAG_NO_FBS;
> 
> Hmmm.... this should work but looks a bit tedious and it could be
> better to have a better mechanism to match devices to their
> port_infos.  Hans, can you please comment?  If getting something more
> structured is too much work, I can go with this but wanna find out
> whether that's the case.

The more structured solution would be v1 of this patch, which I asked
Kefan to change since it seemed overkill. But if you prefer that version
that is fine with me.

Note that as I've already mentioned earlier in the thread this could be
made somewhat cleaner by having an host_flags parameter to
ahci_platform_init_host().

Regards,

Hans