Re: [PATCH v3 7/8] ata: libata: Add libata.force parameter max_sec

[Damien Le Moal <dlemoal@kernel.org>]

On 12/1/25 21:35, Niklas Cassel wrote:
> Add a new libata.force parameter called max_sec.
> 
> The parameter can take an arbitrary value using the format:
> libata.force=max_sec=<param_value>

s/<param_value>/<number of 512B sectors>

This way, we are clear about what the value represents.

> e.g. libata.force=max_sec=8191
> or
> libata.force=max_sec=2048
> 
> This will allow the user to set an arbitrary max_sectors value using
> libata.force.

...to set an arbitrary maximum command size (dev->max_sectors) using...

Again to be clear about what this is doing.

> We cannot remove the existing libata.force parameters "max_sec_128" and
> "max_sec_1024", as these are a part of the exising user facing API.
> 
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 4 ++++
>  drivers/ata/libata-core.c                       | 1 +
>  2 files changed, 5 insertions(+)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 6c42061ca20e5..c5464b11a2ad5 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -3294,6 +3294,10 @@
>  			* [no]logdir: Enable or disable access to the general
>  			  purpose log directory.
>  
> +			* max_sec=<sectors>: Set the transfer size limit, in
> +			  sectors, to the value specified in <sectors>. The

..., in number of 512-Bytes sectors, to...

> +			  value specified in <sectors> has to be an integer.

...to be a non-zero positive integer.

With these addressed, feel free to add:

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research