From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
To: tj@kernel.org
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ata: Check and set 64-bit DMA mask for platform AHCI driver
Date: Sun, 1 Jun 2014 13:23:14 -0500 [thread overview]
Message-ID: <538B6F92.7010009@amd.com> (raw)
In-Reply-To: <1400866510-3130-1-git-send-email-suravee.suthikulpanit@amd.com>
Hi Tejun,
I am following up on this patch.
Thank you,
Suravee
On 05/23/2014 12:35 PM, suravee.suthikulpanit@amd.com wrote:
> From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
>
> The current platform AHCI drier does not set the dma_mask correctly
> for 64-bit DMA capable AHCI controller. This patch checks the AHCI
> capability bit and set the dma_mask and coherent_dma_mask accordingly.
>
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
> ---
> drivers/ata/libahci_platform.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
> index 7cb3a85..85049ef 100644
> --- a/drivers/ata/libahci_platform.c
> +++ b/drivers/ata/libahci_platform.c
> @@ -368,6 +368,15 @@ int ahci_platform_init_host(struct platform_device *pdev,
> ahci_init_controller(host);
> ahci_print_info(host, "platform");
>
> + if (hpriv->cap & HOST_CAP_64) {
> + if (!dev->dma_mask)
> + dev->dma_mask = &dev->coherent_dma_mask;
> +
> + rc = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
> + if (rc)
> + return rc;
> + }
> +
> return ata_host_activate(host, irq, ahci_interrupt, IRQF_SHARED,
> &ahci_platform_sht);
> }
>
next prev parent reply other threads:[~2014-06-01 18:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 17:35 [PATCH 1/1] ata: Check and set 64-bit DMA mask for platform AHCI driver suravee.suthikulpanit
2014-06-01 18:23 ` Suravee Suthikulpanit [this message]
2014-06-03 17:58 ` Tejun Heo
2014-06-06 16:10 ` Suravee Suthikulanit
2014-06-11 9:41 ` Bartlomiej Zolnierkiewicz
2014-06-12 6:22 ` Suravee Suthikulpanit
2014-06-10 21:54 ` David Milburn
2014-06-11 9:30 ` Bartlomiej Zolnierkiewicz
2014-06-12 6:36 ` Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538B6F92.7010009@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).